From d129ed1a1cb8bb1787b06d58de945a482f8d32ab Mon Sep 17 00:00:00 2001 From: Sil Date: Sat, 17 Oct 2026 22:34:05 +0200 Subject: [PATCH 1/2] Standardize QA scripts and shared CI callers Use the merged shared Check and Ready workflows without external review gating, and disable CodeRabbit in this repository. Co-Authored-By: Claude Opus 5.5 --- .coderabbit.yaml | 12 ++++++++++++ .github/workflows/check.yml | 5 ++++- .github/workflows/ready.yml | 6 ++++-- .github/workflows/review-event.yml | 14 -------------- CONTRIBUTING.md | 2 +- README.md | 9 +++++---- apps/docs/package.json | 3 ++- netlify.toml | 4 ++-- package.json | 7 ++++--- 9 files changed, 34 insertions(+), 28 deletions(-) create mode 100644 .coderabbit.yaml delete mode 100644 .github/workflows/review-event.yml diff --git a/.coderabbit.yaml b/.coderabbit.yaml new file mode 100644 index 0000000..a66c5f6 --- /dev/null +++ b/.coderabbit.yaml @@ -0,0 +1,12 @@ +# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json +inheritance: false +reviews: + request_changes_workflow: false + review_status: false + review_progress: false + commit_status: false + auto_review: + enabled: false + auto_incremental_review: false + description_keyword: "" + labels: [] diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 76299d2..4defb90 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -15,4 +15,7 @@ concurrency: jobs: check: name: Check - uses: fulldotdev/.github/.github/workflows/check.yml@288d0a18bdcc83e2376c91f557577f0dfe4d1e56 + uses: fulldotdev/.github/.github/workflows/check.yml@f2895c09a7d688a58f2bacc200c7b18bc07574e7 + with: + runner: blacksmith-4vcpu-ubuntu-2404 + command: vp run check:source diff --git a/.github/workflows/ready.yml b/.github/workflows/ready.yml index 90c69e2..760c278 100644 --- a/.github/workflows/ready.yml +++ b/.github/workflows/ready.yml @@ -14,10 +14,11 @@ on: unlabeled, ] workflow_run: - workflows: [Check, Review event] + workflows: [Check] types: [completed] permissions: + actions: read contents: write pull-requests: write statuses: write @@ -25,8 +26,9 @@ permissions: jobs: ready: - uses: fulldotdev/.github/.github/workflows/ready.yml@579bcf444a2f964e48ecbeb580b01c921c9f1ea4 + uses: fulldotdev/.github/.github/workflows/ready.yml@f2895c09a7d688a58f2bacc200c7b18bc07574e7 with: + runner: blacksmith-2vcpu-ubuntu-2404 netlify-checks: '["netlify/fulldev-sitex/deploy-preview"]' merge-app-client-id: ${{ vars.RELEASE_APP_CLIENT_ID }} secrets: diff --git a/.github/workflows/review-event.yml b/.github/workflows/review-event.yml deleted file mode 100644 index ec42697..0000000 --- a/.github/workflows/review-event.yml +++ /dev/null @@ -1,14 +0,0 @@ -name: Review event - -on: - pull_request_review: - types: [submitted, dismissed] - -permissions: {} - -jobs: - notify: - runs-on: ubuntu-latest - timeout-minutes: 1 - steps: - - run: echo "Review changed; the trusted Ready workflow will inspect GitHub metadata." diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 0741cb0..daa8912 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -14,7 +14,7 @@ pnpm dev Run these before opening a pull request: ```bash -pnpm check +vp run check:source pnpm ready ``` diff --git a/README.md b/README.md index da92b0a..c504b07 100644 --- a/README.md +++ b/README.md @@ -13,10 +13,11 @@ packages/sitex/ # @fulldotdev/sitex package source ## Scripts ```bash -pnpm dev # run the docs app -pnpm build # build all workspace packages/apps -pnpm check # format, lint, and typecheck -pnpm ready # check and build everything +pnpm dev # run the docs app +pnpm build # build all workspace packages/apps +vp run check:build # typecheck the docs app with the types its build generated +vp run check:source # format, lint, and typecheck +pnpm ready # check and build everything ``` ## Package diff --git a/apps/docs/package.json b/apps/docs/package.json index 95ccf32..f1b56ee 100644 --- a/apps/docs/package.json +++ b/apps/docs/package.json @@ -5,7 +5,8 @@ "type": "module", "scripts": { "dev": "vp dev --host 127.0.0.1 --port 4323", - "build": "shadcn build && vp build && tsc --noEmit", + "build": "shadcn build && vp build", + "check:build": "tsc --noEmit", "preview": "vp preview --host 127.0.0.1 --port 4323", "registry:build": "shadcn build" }, diff --git a/netlify.toml b/netlify.toml index 2003881..dee62e0 100644 --- a/netlify.toml +++ b/netlify.toml @@ -1,5 +1,5 @@ [build] -command = "pnpm build" +command = "pnpm build && pnpm run check:build" publish = "apps/docs/dist" [build.environment] @@ -79,7 +79,7 @@ to = "/docs/components/:splat" status = 301 [context.production] -command = "pnpm run check && pnpm build" +command = "pnpm run check:source && pnpm build && pnpm run check:build" [[headers]] for = "/*" diff --git a/package.json b/package.json index d6ad44a..c57e62e 100644 --- a/package.json +++ b/package.json @@ -4,11 +4,12 @@ "private": true, "type": "module", "scripts": { - "ready": "vp check && vp run @fulldotdev/sitex#check && vp run -r build", + "ready": "vp run check:source && vp run build && vp run check:build", "dev": "vp run docs#dev", "build": "vp run -r build", - "check": "vp check && vp run @fulldotdev/sitex#check", - "format": "vp fmt", + "check:build": "vp run docs#check:build", + "check:source": "vp check && vp run @fulldotdev/sitex#check", + "fix:source": "vp check --fix", "preview": "vp run docs#preview", "changeset": "changeset", "release": "changeset version && pnpm install --lockfile-only && vp fmt", From f1ec3e58f70d66a3dccef8e025121204f5cacffb Mon Sep 17 00:00:00 2001 From: Sil Date: Sat, 17 Oct 2026 22:48:43 +0200 Subject: [PATCH 2/2] Record QA-only change without a package release --- .changeset/qa-workflow-standardization.md | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .changeset/qa-workflow-standardization.md diff --git a/.changeset/qa-workflow-standardization.md b/.changeset/qa-workflow-standardization.md new file mode 100644 index 0000000..a845151 --- /dev/null +++ b/.changeset/qa-workflow-standardization.md @@ -0,0 +1,2 @@ +--- +---