What problem would this solve?
While installing in the user folder is more convenient, it also poses a security risk. If any other program tampers with the files of an app installed in it, there will be no warning or protection. A malicious program could replace the VaultType.exe with a version containing a backdoor that steals passwords without the user noticing. Even if this leads to Windows warning again about an untrusted file on next startup, users might just assume it's normal since that happened on first start too, or they think it was updated.
I manually had to start the installer as admin and select the Program Files folder as installation target, but most users probably won't think of this or be even aware that otherwise they don't get UAC protection.
What I also don't know yet (as there hasn't been an update since first installation) is whether I broke the auto-updater by doing it.
Proposed solution
The installer should request to run as admin and default to install in the program files folder. You already offer a portable option for users who want to trade security for flexibility (though I think the README and/or release notes should warn about this), but an installation should make use of the OS security features.
Alternatives considered
Some installers let users choose between two options "install for all users" and "install only for me", which is controlling whether it gets installed in the program files or user folder, but usually without explicitly telling the user this or in general what the implications of this are, especially that the "install only for me" option is less secure.
For a security critical application like VaultType I don't think that's a good idea, it should really only offer the program files folder. As I said, there's still the portable option.
Confirmation
What problem would this solve?
While installing in the user folder is more convenient, it also poses a security risk. If any other program tampers with the files of an app installed in it, there will be no warning or protection. A malicious program could replace the VaultType.exe with a version containing a backdoor that steals passwords without the user noticing. Even if this leads to Windows warning again about an untrusted file on next startup, users might just assume it's normal since that happened on first start too, or they think it was updated.
I manually had to start the installer as admin and select the Program Files folder as installation target, but most users probably won't think of this or be even aware that otherwise they don't get UAC protection.
What I also don't know yet (as there hasn't been an update since first installation) is whether I broke the auto-updater by doing it.
Proposed solution
The installer should request to run as admin and default to install in the program files folder. You already offer a portable option for users who want to trade security for flexibility (though I think the README and/or release notes should warn about this), but an installation should make use of the OS security features.
Alternatives considered
Some installers let users choose between two options "install for all users" and "install only for me", which is controlling whether it gets installed in the program files or user folder, but usually without explicitly telling the user this or in general what the implications of this are, especially that the "install only for me" option is less secure.
For a security critical application like VaultType I don't think that's a good idea, it should really only offer the program files folder. As I said, there's still the portable option.
Confirmation