Fix: Make logs configurable, fix cfgrib index placement, and improve posix error handling#4
Merged
Merged
Conversation
…ronment variable, 2. dismantle auto deleting the logs after writing 3. write the grib idx file in cache where other cache are located to avoid japardizing the original files of user 4. check if the file exist or not before trying yo detect the format
Contributor
Author
|
@antarcticrainforest I think we are ready to go to main here, yes? the issue with cfgrib index file and also the logs issue are resolved |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we make logs configurable via the
XARRAY_PRISM_LOG_LEVELenvironment variable, remove the terminal line-clearing behavior after detection messages, redirect cfgrib index files to the prism cache directory to avoid writing into the user's original data directories, and raise a clearFileNotFoundErrorfor missing local files instead of the misleading "cannot detect format" error.