Context
Area
crates/syntonia/src/serial.rs — HardwareSerialPort dead-code suppression.
Severity
low — explicit suppression admitting unwired production code.
Evidence
crates/syntonia/src/serial.rs:52-53 — #[expect(dead_code, reason = "public hardware adapter; consumers live outside this crate (baofeng::protocol module not yet re-wired, see #80-follow-up)")]crates/syntonia/src/serial.rs:66-69 — same suppression on HardwareSerialPort::open.
Conflict
The standard requires features to be implemented, wired, and exercised. A dead_code suppression on the production hardware adapter — with a reason explicitly stating "not yet re-wired" — is an admission that the feature is not wired.
Why it matters
Suppressions that paper over unwired code hide the gap from linters but not from operators. This is the textbook case of "suppressions are violations" (kanon#321).
Done criteria
- Remove the
dead_code suppressions by wiring HardwareSerialPort into the Baofeng protocol driver and the akroasis binary.
- Closes naturally when finding-3 (radio hardware unwired) is fixed.
Source
Kimi L1+L2 audit pipeline 2026-04-25.
Related to akroasis hardware-radio finding (filed separately) and kanon#321 (suppressions as gate-blocking violations).
Provenance
Originally filed on the kanon forge as issue #15 on 2026-04-25T20:15:18.718822625-05:00[America/Chicago]. Recovered from 2026-05-09 pre-brick restic backup. Forge URL no longer reachable post firmware brick.
Severity
P2
Context
Area
crates/syntonia/src/serial.rs—HardwareSerialPortdead-code suppression.Severity
low — explicit suppression admitting unwired production code.
Evidence
crates/syntonia/src/serial.rs:52-53—#[expect(dead_code, reason = "public hardware adapter; consumers live outside this crate (baofeng::protocol module not yet re-wired, see #80-follow-up)")]crates/syntonia/src/serial.rs:66-69— same suppression onHardwareSerialPort::open.Conflict
The standard requires features to be implemented, wired, and exercised. A
dead_codesuppression on the production hardware adapter — with a reason explicitly stating "not yet re-wired" — is an admission that the feature is not wired.Why it matters
Suppressions that paper over unwired code hide the gap from linters but not from operators. This is the textbook case of "suppressions are violations" (kanon#321).
Done criteria
dead_codesuppressions by wiringHardwareSerialPortinto the Baofeng protocol driver and the akroasis binary.Source
Kimi L1+L2 audit pipeline 2026-04-25.
Related to akroasis hardware-radio finding (filed separately) and kanon#321 (suppressions as gate-blocking violations).
Provenance
Originally filed on the kanon forge as issue #15 on 2026-04-25T20:15:18.718822625-05:00[America/Chicago]. Recovered from 2026-05-09 pre-brick restic backup. Forge URL no longer reachable post firmware brick.
Severity
P2