Introduce resource-level filter for Receiver#1314
Merged
Merged
Conversation
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
5b58c15 to
bed3dc5
Compare
Member
Author
|
@stefanprodan I successfully tested this API e2e across all my Receiver paths in an EKS fleet with 4 clusters. |
stefanprodan
approved these changes
May 23, 2026
Member
stefanprodan
left a comment
There was a problem hiding this comment.
LGTM
Thanks @matheuscscp 🏅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #1313
CEL expressions get ugly fast (in general).
This PR introduces a
.spec.resources[]-level.filterto enhance the readability for filtering CEL expressions in Receiver.Note:
.spec.resourceFilterand.spec.resources[].filterare stacked together i.e. they are AND'd together. If both are set, then both have to returntruefor a resource to be triggered.Before this PR:
After this PR: