Commit a2464cc
committed
fix(skilldoc): make card check EOL-insensitive (Windows CI) + satisfy errcheck
Two CI failures on PR #56, both real:
- build (windows-latest): `skilldoc check` reported all 19 cards stale. Root cause:
the fence freshness check compares the card's fence block byte-for-byte against a
generated (LF) render, but Windows git checks the cards out with CRLF, so every
comparison mismatched. Fix the root cause — normalize CRLF→LF on read (the
generated fence is canonical LF) so the tool is insensitive to checkout settings —
and add a .gitattributes pinning the cards to LF so the committed files stay
canonical. ubuntu/macos were already green.
- lint (golangci-lint / errcheck): two unchecked fmt.Fprint* return values in
main.go (the 'cards OK' line and the per-issue print loop). Propagate both errors.
New regression test TestRunCheck_CRLFCardIsClean. Local: go test green, golangci-lint
0 issues, check-cards OK.1 parent af922ce commit a2464cc
3 files changed
Lines changed: 40 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
76 | | - | |
| 75 | + | |
| 76 | + | |
77 | 77 | | |
78 | 78 | | |
79 | 79 | | |
| |||
90 | 90 | | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
156 | 156 | | |
157 | 157 | | |
158 | 158 | | |
159 | | - | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
160 | 162 | | |
161 | 163 | | |
162 | 164 | | |
| |||
191 | 193 | | |
192 | 194 | | |
193 | 195 | | |
194 | | - | |
| 196 | + | |
195 | 197 | | |
196 | 198 | | |
197 | 199 | | |
| |||
200 | 202 | | |
201 | 203 | | |
202 | 204 | | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
203 | 211 | | |
204 | 212 | | |
205 | 213 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
90 | 112 | | |
91 | 113 | | |
92 | 114 | | |
| |||
0 commit comments