Skip to content

deps: Binary downloader discards custom binary name for archive source #68

@adityathebe

Description

@adityathebe

When a custom binary name is provided and the source is an archive file, the custom binary name is dicarded.

https://github.com/flanksource/commons/blob/master/deps/deps.go#L354

Example:


"trivy": {
		Version:    "0.40.0", // without the "v" prefix
		Linux:      "https://github.com/aquasecurity/trivy/releases/download/v{{.version}}/trivy_{{.version}}_Linux-64bit.tar.gz",
		Windows:    "https://github.com/aquasecurity/trivy/releases/download/v{{.version}}/trivy_{{.version}}_windows-64bit.zip",
		Macosx:     "https://github.com/aquasecurity/trivy/releases/download/v{{.version}}/trivy_{{.version}}_macOS-64bit.tar.gz",
		BinaryName: "trivy-{{.version}}",
	},
Behavior Outcome
Expected Download as trivy-0.40.0
Current Download as trivy

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions