refactor(tests): migrate conftest fixtures from StateMachine to StateChart

- Switch all 7 inline fixture classes to StateChart
- Add error_on_execution=False to validator fixture (test expects direct propagation)
- Remove classic_traffic_light_machine_allow_event subclass (redundant with StateChart default)
- Remove TransitionNotAllowed tests from test_statemachine.py (covered by compat tests)

Author: fgmacedo

tests/conftest.py

@@ -27,9 +27,9 @@ def current_time():
 def campaign_machine():
     "Define a new class for each test"
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class CampaignMachine(StateMachine):
+    class CampaignMachine(StateChart):
         "A workflow machine"
 
         draft = State(initial=True)
@@ -47,11 +47,13 @@ class CampaignMachine(StateMachine):
 def campaign_machine_with_validator():
     "Define a new class for each test"
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class CampaignMachine(StateMachine):
+    class CampaignMachine(StateChart):
         "A workflow machine"
 
+        error_on_execution = False
+
         draft = State(initial=True)
         producing = State("Being produced")
         closed = State(final=True)
@@ -71,9 +73,9 @@ def can_produce(*args, **kwargs):
 def campaign_machine_with_final_state():
     "Define a new class for each test"
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class CampaignMachine(StateMachine):
+    class CampaignMachine(StateChart):
         "A workflow machine"
 
         draft = State(initial=True)
@@ -91,9 +93,9 @@ class CampaignMachine(StateMachine):
 def campaign_machine_with_values():
     "Define a new class for each test"
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class CampaignMachineWithKeys(StateMachine):
+    class CampaignMachineWithKeys(StateChart):
         "A workflow machine"
 
         draft = State(initial=True, value=1)
@@ -131,9 +133,9 @@ def AllActionsMachine():
 @pytest.fixture()
 def classic_traffic_light_machine(engine):
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class TrafficLightMachine(StateMachine):
+    class TrafficLightMachine(StateChart):
         green = State(initial=True)
         yellow = State()
         red = State()
@@ -150,18 +152,16 @@ def _get_engine(self):
 
 @pytest.fixture()
 def classic_traffic_light_machine_allow_event(classic_traffic_light_machine):
-    class TrafficLightMachineAllowingEventWithoutTransition(classic_traffic_light_machine):
-        allow_event_without_transition = True
-
-    return TrafficLightMachineAllowingEventWithoutTransition
+    """Already allow_event_without_transition=True (StateChart default)."""
+    return classic_traffic_light_machine
 
 
 @pytest.fixture()
 def reverse_traffic_light_machine():
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class ReverseTrafficLightMachine(StateMachine):
+    class ReverseTrafficLightMachine(StateChart):
         "A traffic light machine"
 
         green = State(initial=True)
@@ -177,9 +177,9 @@ class ReverseTrafficLightMachine(StateMachine):
 @pytest.fixture()
 def approval_machine(current_time):  # noqa: C901
     from statemachine import State
-    from statemachine import StateMachine
+    from statemachine import StateChart
 
-    class ApprovalMachine(StateMachine):
+    class ApprovalMachine(StateChart):
         "A workflow machine"
 
         requested = State(initial=True)

tests/test_statemachine.py

@@ -156,25 +156,6 @@ def test_should_change_state_with_multiple_machine_instances(campaign_machine):
     assert machine2.current_state == campaign_machine.producing
 
 
-@pytest.mark.parametrize(
-    ("current_state", "transition"),
-    [
-        ("draft", "deliver"),
-        ("closed", "add_job"),
-    ],
-)
-def test_call_to_transition_that_is_not_in_the_current_state_should_raise_exception(
-    campaign_machine, current_state, transition
-):
-    model = MyModel(state=current_state)
-    machine = campaign_machine(model)
-
-    assert machine.current_state.value == current_state
-
-    with pytest.raises(exceptions.TransitionNotAllowed):
-        machine.send(transition)
-
-
 def test_machine_should_list_allowed_events_in_the_current_state(campaign_machine):
     model = MyModel()
     machine = campaign_machine(model)
@@ -208,18 +189,6 @@ def test_machine_should_run_a_transition_by_his_key(campaign_machine):
     assert machine.current_state == machine.producing
 
 
-def test_machine_should_raise_an_exception_if_a_transition_by_his_key_is_not_found(
-    campaign_machine,
-):
-    model = MyModel()
-    machine = campaign_machine(model)
-
-    assert model.state == "draft"
-
-    with pytest.raises(exceptions.TransitionNotAllowed):
-        machine.send("go_horse")
-
-
 def test_machine_should_use_and_model_attr_other_than_state(campaign_machine):
     model = MyModel(status="producing")
     machine = campaign_machine(model, state_field="status")