[refactor] Reality OS: cleaning dead code from Typer's vendored Click #1846
Closed
wallerphilip-cpu
started this conversation in
Show and tell
Replies: 1 comment
-
|
Thanks for the note and the offer 🙏 There's no need to PR this though, as we're actively working on refactoring the vendored Click code, and the PR you'd submit would only conflict with ongoing work. We also prefer to do this with substantial human oversight, as this will set the foundation for future Typer. The core maintainers team will be in charge of leading this effort 😉 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
I'm working on a cleanup of Typer as part of "Reality OS" — removing unused code from the vendored Click compatibility layer.
Initial scan with vulture (80% confidence) found ~10 unused imports/variables:
Plus the already-removed unused TYPE_CHECKING import in testing.py (PR #1845).
Plan:
Opening this discussion before the PR as requested in CONTRIBUTING. Happy to break it into smaller PRs if preferred.
Beta Was this translation helpful? Give feedback.
All reactions