Fixed ruff errors

Author: vodkar

backend/app/alembic/__init__.py

@@ -1,7 +1,11 @@
+"""Alembic configuration for database migrations."""
 from logging.config import fileConfig
 
 from alembic import context
 from sqlalchemy import engine_from_config, pool
+from sqlmodel import SQLModel
+
+from app.core.config import settings
 
 # this is the Alembic Config object, which provides
 # access to the values within the .ini file in use.
@@ -12,14 +16,11 @@
 if config.config_file_name:
     fileConfig(config.config_file_name)
 
-
-from app.core.config import settings  # noqa
-from sqlmodel import SQLModel
-
 target_metadata = SQLModel.metadata
 
 
 def get_url() -> str:
+    """Get database URL from settings."""
     return str(settings.SQLALCHEMY_DATABASE_URI)
 
 

backend/app/alembic/env.py

@@ -1,4 +1,4 @@
-"""Add cascade delete relationships
+"""Add cascade delete relationships.
 
 Revision ID: 1a31ce608336
 Revises: d98dd8ec85a3
@@ -17,8 +17,11 @@
 
 
 def upgrade() -> None:
+    """Upgrade database schema."""
     # ### commands auto generated by Alembic - please adjust! ###
-    op.alter_column("item", "owner_id", existing_type=sa.UUID(), nullable=False)
+    op.alter_column(
+        "item", "owner_id", existing_type=sa.UUID(), nullable=False,
+    )
     op.drop_constraint("item_owner_id_fkey", "item", type_="foreignkey")
     op.create_foreign_key(
         None, "item", "user", ["owner_id"], ["id"], ondelete="CASCADE",
@@ -27,8 +30,11 @@ def upgrade() -> None:
 
 
 def downgrade() -> None:
+    """Downgrade database schema."""
     # ### commands auto generated by Alembic - please adjust! ###
     op.drop_constraint("item_owner_id_fkey", "item", type_="foreignkey")
-    op.create_foreign_key("item_owner_id_fkey", "item", "user", ["owner_id"], ["id"])
+    op.create_foreign_key(
+        "item_owner_id_fkey", "item", "user", ["owner_id"], ["id"],
+    )
     op.alter_column("item", "owner_id", existing_type=sa.UUID(), nullable=True)
     # ### end Alembic commands ###

backend/app/alembic/versions/1a31ce608336_add_cascade_delete_relationships.py

@@ -1,4 +1,4 @@
-"""Add max length for string(varchar) fields in User and Items models
+"""Add max length for string(varchar) fields in User and Items models.
 
 Revision ID: 9c0a54914c78
 Revises: e2412789c190
@@ -17,6 +17,7 @@
 
 
 def upgrade() -> None:
+    """Upgrade database schema."""
     # Adjust the length of the email field in the User table
     op.alter_column(
         "user",
@@ -55,6 +56,7 @@ def upgrade() -> None:
 
 
 def downgrade() -> None:
+    """Downgrade database schema."""
     # Revert the length of the email field in the User table
     op.alter_column(
         "user",

backend/app/alembic/versions/9c0a54914c78_add_max_length_for_string_varchar_.py

@@ -1,4 +1,4 @@
-"""Edit replace id integers in all models to use UUID instead
+"""Edit replace id integers in all models to use UUID instead.
 
 Revision ID: d98dd8ec85a3
 Revises: 9c0a54914c78
@@ -18,6 +18,7 @@
 
 
 def upgrade() -> None:
+    """Upgrade database schema."""
     # Ensure uuid-ossp extension is available
     op.execute('CREATE EXTENSION IF NOT EXISTS "uuid-ossp"')
 
@@ -39,14 +40,18 @@ def upgrade() -> None:
         ),
     )
     op.add_column(
-        "item", sa.Column("new_owner_id", postgresql.UUID(as_uuid=True), nullable=True),
+        "item",
+        sa.Column(
+            "new_owner_id", postgresql.UUID(as_uuid=True), nullable=True,
+        ),
     )
 
     # Populate the new columns with UUIDs
     op.execute('UPDATE "user" SET new_id = uuid_generate_v4()')
     op.execute("UPDATE item SET new_id = uuid_generate_v4()")
     op.execute(
-        'UPDATE item SET new_owner_id = (SELECT new_id FROM "user" WHERE "user".id = item.owner_id)',
+        'UPDATE item SET new_owner_id = '
+        '(SELECT new_id FROM "user" WHERE "user".id = item.owner_id)',
     )
 
     # Set the new_id as not nullable
@@ -69,10 +74,13 @@ def upgrade() -> None:
     op.create_primary_key("item_pkey", "item", ["id"])
 
     # Recreate foreign key constraint
-    op.create_foreign_key("item_owner_id_fkey", "item", "user", ["owner_id"], ["id"])
+    op.create_foreign_key(
+        "item_owner_id_fkey", "item", "user", ["owner_id"], ["id"],
+    )
 
 
 def downgrade() -> None:
+    """Downgrade database schema."""
     # Reverse the upgrade process
     op.add_column("user", sa.Column("old_id", sa.Integer, autoincrement=True))
     op.add_column("item", sa.Column("old_id", sa.Integer, autoincrement=True))
@@ -81,22 +89,28 @@ def downgrade() -> None:
     # Populate the old columns with default values
     # Generate sequences for the integer IDs if not exist
     op.execute(
-        'CREATE SEQUENCE IF NOT EXISTS user_id_seq AS INTEGER OWNED BY "user".old_id',
+        'CREATE SEQUENCE IF NOT EXISTS user_id_seq AS INTEGER '
+        'OWNED BY "user".old_id',
     )
     op.execute(
-        "CREATE SEQUENCE IF NOT EXISTS item_id_seq AS INTEGER OWNED BY item.old_id",
+        "CREATE SEQUENCE IF NOT EXISTS item_id_seq AS INTEGER "
+        "OWNED BY item.old_id",
     )
 
     op.execute(
-        "SELECT setval('user_id_seq', COALESCE((SELECT MAX(old_id) + 1 FROM \"user\"), 1), false)",
+        "SELECT setval('user_id_seq', "
+        'COALESCE((SELECT MAX(old_id) + 1 FROM "user"), 1), false)',
     )
     op.execute(
-        "SELECT setval('item_id_seq', COALESCE((SELECT MAX(old_id) + 1 FROM item), 1), false)",
+        "SELECT setval('item_id_seq', "
+        "COALESCE((SELECT MAX(old_id) + 1 FROM item), 1), false)",
     )
 
     op.execute("UPDATE \"user\" SET old_id = nextval('user_id_seq')")
     op.execute(
-        'UPDATE item SET old_id = nextval(\'item_id_seq\'), old_owner_id = (SELECT old_id FROM "user" WHERE "user".id = item.owner_id)',
+        'UPDATE item SET old_id = nextval(\'item_id_seq\'), '
+        'old_owner_id = (SELECT old_id FROM "user" '
+        'WHERE "user".id = item.owner_id)',
     )
 
     # Drop new columns and rename old columns back
@@ -115,4 +129,6 @@ def downgrade() -> None:
     op.create_primary_key("item_pkey", "item", ["id"])
 
     # Recreate foreign key constraint
-    op.create_foreign_key("item_owner_id_fkey", "item", "user", ["owner_id"], ["id"])
+    op.create_foreign_key(
+        "item_owner_id_fkey", "item", "user", ["owner_id"], ["id"],
+    )

backend/app/alembic/versions/__init__.py

@@ -1,4 +1,4 @@
-"""Initialize models
+"""Initialize models.
 
 Revision ID: e2412789c190
 Revises:
@@ -18,13 +18,16 @@
 
 
 def upgrade() -> None:
+    """Upgrade database schema."""
     # ### commands auto generated by Alembic - please adjust! ###
     op.create_table(
         "user",
         sa.Column("email", sqlmodel.sql.sqltypes.AutoString(), nullable=False),
         sa.Column("is_active", sa.Boolean(), nullable=False),
         sa.Column("is_superuser", sa.Boolean(), nullable=False),
-        sa.Column("full_name", sqlmodel.sql.sqltypes.AutoString(), nullable=True),
+        sa.Column(
+            "full_name", sqlmodel.sql.sqltypes.AutoString(), nullable=True,
+        ),
         sa.Column("id", sa.Integer(), nullable=False),
         sa.Column(
             "hashed_password",
@@ -36,7 +39,9 @@ def upgrade() -> None:
     op.create_index(op.f("ix_user_email"), "user", ["email"], unique=True)
     op.create_table(
         "item",
-        sa.Column("description", sqlmodel.sql.sqltypes.AutoString(), nullable=True),
+        sa.Column(
+            "description", sqlmodel.sql.sqltypes.AutoString(), nullable=True,
+        ),
         sa.Column("id", sa.Integer(), nullable=False),
         sa.Column("title", sqlmodel.sql.sqltypes.AutoString(), nullable=False),
         sa.Column("owner_id", sa.Integer(), nullable=False),
@@ -50,6 +55,7 @@ def upgrade() -> None:
 
 
 def downgrade() -> None:
+    """Downgrade database schema."""
     # ### commands auto generated by Alembic - please adjust! ###
     op.drop_table("item")
     op.drop_index(op.f("ix_user_email"), table_name="user")

backend/app/alembic/versions/d98dd8ec85a3_edit_replace_id_integers_in_all_models_.py

@@ -1,3 +1,5 @@
+"""API dependency functions."""
+
 from collections.abc import Generator
 from typing import Annotated
 
@@ -19,6 +21,7 @@
 
 
 def get_db() -> Generator[Session]:
+    """Get database session."""
     with Session(engine) as session:
         yield session
 
@@ -28,6 +31,7 @@ def get_db() -> Generator[Session]:
 
 
 def get_current_user(session: SessionDep, token: TokenDep) -> User:
+    """Get current user from JWT token."""
     try:
         payload = jwt.decode(
             token,
@@ -39,7 +43,7 @@ def get_current_user(session: SessionDep, token: TokenDep) -> User:
         raise HTTPException(
             status_code=status.HTTP_403_FORBIDDEN,
             detail="Could not validate credentials",
-        )
+        ) from None
     user = session.get(User, token_data.sub)
     if not user:
         raise HTTPException(status_code=404, detail="User not found")
@@ -52,6 +56,7 @@ def get_current_user(session: SessionDep, token: TokenDep) -> User:
 
 
 def get_current_active_superuser(current_user: CurrentUser) -> User:
+    """Get current active superuser."""
     if not current_user.is_superuser:
         raise HTTPException(
             status_code=403,

backend/app/alembic/versions/e2412789c190_initialize_models.py

@@ -1,3 +1,5 @@
+"""API router configuration."""
+
 from fastapi import APIRouter
 
 from app.api.routes import items, login, private, users, utils

backend/app/api/deps.py

@@ -1,3 +1,5 @@
+"""Item management API endpoints."""
+
 import uuid
 
 # Removed unused Any import
@@ -10,7 +12,7 @@
 router = APIRouter(prefix="/items", tags=["items"])
 
 
-@router.get("/", response_model=ItemsPublic)
+@router.get("/")
 def read_items(
     session: SessionDep,
     current_user: CurrentUser,
@@ -41,20 +43,20 @@ def read_items(
     return ItemsPublic(data=items, count=count)
 
 
-@router.get("/{id}", response_model=ItemPublic)
+@router.get("/{item_id}")
 def read_item(
-    session: SessionDep, current_user: CurrentUser, id: uuid.UUID,
+    session: SessionDep, current_user: CurrentUser, item_id: uuid.UUID,
 ) -> ItemPublic:
     """Get item by ID."""
-    item = session.get(Item, id)
+    item = session.get(Item, item_id)
     if not item:
         raise HTTPException(status_code=404, detail="Item not found")
     if not current_user.is_superuser and (item.owner_id != current_user.id):
         raise HTTPException(status_code=400, detail="Not enough permissions")
     return ItemPublic.model_validate(item)
 
 
-@router.post("/", response_model=ItemPublic)
+@router.post("/")
 def create_item(
     *,
     session: SessionDep,
@@ -69,16 +71,16 @@ def create_item(
     return ItemPublic.model_validate(item)
 
 
-@router.put("/{id}", response_model=ItemPublic)
+@router.put("/{item_id}")
 def update_item(
     *,
     session: SessionDep,
     current_user: CurrentUser,
-    id: uuid.UUID,
+    item_id: uuid.UUID,
     item_in: ItemUpdate,
 ) -> ItemPublic:
     """Update an item."""
-    item = session.get(Item, id)
+    item = session.get(Item, item_id)
     if not item:
         raise HTTPException(status_code=404, detail="Item not found")
     if not current_user.is_superuser and (item.owner_id != current_user.id):
@@ -91,14 +93,14 @@ def update_item(
     return ItemPublic.model_validate(item)
 
 
-@router.delete("/{id}")
+@router.delete("/{item_id}")
 def delete_item(
     session: SessionDep,
     current_user: CurrentUser,
-    id: uuid.UUID,
+    item_id: uuid.UUID,
 ) -> Message:
     """Delete an item."""
-    item = session.get(Item, id)
+    item = session.get(Item, item_id)
     if not item:
         raise HTTPException(status_code=404, detail="Item not found")
     if not current_user.is_superuser and (item.owner_id != current_user.id):