Skip to content

Commit 57f365a

Browse files
fix: add Changethis1! to default secret check (Devin Review)
The MSSQL default password Changethis1! was not caught by the _check_default_secret security guard, allowing deployments with default credentials. Now checks both 'changethis' and 'Changethis1!'. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 parent e4e1642 commit 57f365a

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

backend/app/core/config.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,10 @@ def emails_enabled(self) -> bool:
9595
FIRST_SUPERUSER_PASSWORD: str
9696

9797
def _check_default_secret(self, var_name: str, value: str | None) -> None:
98-
if value == "changethis":
98+
default_secrets = ("changethis", "Changethis1!")
99+
if value in default_secrets:
99100
message = (
100-
f'The value of {var_name} is "changethis", '
101+
f"The value of {var_name} is a default placeholder, "
101102
"for security, please change it, at least for deployments."
102103
)
103104
if self.ENVIRONMENT == "local":

0 commit comments

Comments
 (0)