From 2660c144728bf3f605543efec47492d4a50419ce Mon Sep 17 00:00:00 2001 From: Himura Kazuto Date: Wed, 29 Jul 2026 10:05:57 +0400 Subject: [PATCH 1/2] fix: update terminology from "series number" to "number in series" (less confusion) --- README.md | 2 +- app/Controllers/CsvImportController.php | 2 +- locale/en_US.json | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 908ffe61..3566b81d 100644 --- a/README.md +++ b/README.md @@ -901,7 +901,7 @@ Pinakes v0.7.x introduced a full library-interoperability layer, delivered as op - Collane now support an optional umbrella group for related spin-offs, universes, or franchises, so separate series like `Fairy Tail`, `Fairy Tail: 100 Year Quest`, and `Fairy Tail: Happy` can remain distinct while sharing one parent group. - Collane also support an optional cycle/season label plus numeric ordering, matching LibraryThing-style series such as `The Worlds of Aldebaran` with `Cycle 1`, `Cycle 2`, and later arcs. -- Book create/edit forms can set group, cycle/season, cycle order, series name, and series number in one flow; the Collane admin page exposes the same metadata and shows related series in the same group. +- Book create/edit forms can set group, cycle/season, cycle order, series name, and number in series in one flow; the Collane admin page exposes the same metadata and shows related series in the same group. ### Archives plugin (ISAD(G) / ISAAR(CPF)) diff --git a/app/Controllers/CsvImportController.php b/app/Controllers/CsvImportController.php index 3aa353e6..b5163a55 100644 --- a/app/Controllers/CsvImportController.php +++ b/app/Controllers/CsvImportController.php @@ -1099,7 +1099,7 @@ private function mapColumnHeaders(array $headers): array 'prezzo' => ['prezzo', 'price', 'precio', 'prix', 'preis', 'list price', 'purchase price'], 'copie_totali' => ['copie_totali', 'copie', 'copies', 'quantity', 'quantità', 'cantidad'], 'collana' => ['collana', 'series', 'collection', 'collections', 'colección', 'reihe'], - 'numero_serie' => ['numero_serie', 'series number', 'número de serie', 'numéro de série'], + 'numero_serie' => ['numero_serie', 'number in series', 'número de serie', 'numéro de série'], 'traduttore' => ['traduttore', 'translator', 'traductor', 'traducteur', 'übersetzer'], 'illustratore' => ['illustratore', 'illustrator', 'ilustrador', 'illustrateur', 'zeichner'], 'parole_chiave' => ['parole_chiave', 'parole chiave', 'keywords', 'tags', 'palabras clave', 'mots-clés', 'schlagwörter', 'subjects'], diff --git a/locale/en_US.json b/locale/en_US.json index 7c092157..ec04ba2b 100644 --- a/locale/en_US.json +++ b/locale/en_US.json @@ -3218,7 +3218,7 @@ "Numero Inventario": "Inventory Number", "Numero Libri": "Number of Books", "Numero Pagine": "Number of Pages", - "Numero Serie": "Series Number", + "Numero Serie": "Number in Series", "Numero colonne non valido": "Invalid column count", "Numero di Pagine": "Number of Pages", "Numero di copie non valido.": "Invalid number of copies.", @@ -3228,7 +3228,7 @@ "Numero massimo di righe superato (%d). Dividi il file in parti più piccole.": "Maximum number of rows exceeded (%d). Split the file into smaller parts.", "Numero o descrizione dell'edizione": "Edition number or description", "Numero prenotazioni attive": "Number of active reservations", - "Numero serie": "Series number", + "Numero serie": "Number in series", "Numero tessera": "Card number", "Numero volume": "Volume number", "Nuova Collana": "New Series", From 270fae306c99d143a57dbbccd5b8f104dd3b2860 Mon Sep 17 00:00:00 2001 From: Vladislav Glagolev Date: Fri, 31 Jul 2026 11:20:10 +0400 Subject: [PATCH 2/2] Apply suggestion from reviewer --- app/Controllers/CsvImportController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Controllers/CsvImportController.php b/app/Controllers/CsvImportController.php index b5163a55..23dfd31a 100644 --- a/app/Controllers/CsvImportController.php +++ b/app/Controllers/CsvImportController.php @@ -1099,7 +1099,7 @@ private function mapColumnHeaders(array $headers): array 'prezzo' => ['prezzo', 'price', 'precio', 'prix', 'preis', 'list price', 'purchase price'], 'copie_totali' => ['copie_totali', 'copie', 'copies', 'quantity', 'quantità', 'cantidad'], 'collana' => ['collana', 'series', 'collection', 'collections', 'colección', 'reihe'], - 'numero_serie' => ['numero_serie', 'number in series', 'número de serie', 'numéro de série'], + 'numero_serie' => ['numero_serie', 'series number', 'number in series', 'número de serie', 'numéro de série'], 'traduttore' => ['traduttore', 'translator', 'traductor', 'traducteur', 'übersetzer'], 'illustratore' => ['illustratore', 'illustrator', 'ilustrador', 'illustrateur', 'zeichner'], 'parole_chiave' => ['parole_chiave', 'parole chiave', 'keywords', 'tags', 'palabras clave', 'mots-clés', 'schlagwörter', 'subjects'],