From 051f1b68ece3b738ab1ed9211e876c0b9e0e7ed2 Mon Sep 17 00:00:00 2001
From: Hannes Achleitner <hannes.software@gmx.at>
Date: Wed, 8 Apr 2026 07:42:56 +0200
Subject: [PATCH] Diff saved as screenshotDiffs/null, not picked up by upload
 loop
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The bug is clear. $name (line 5, the git-relative path) is always the correct source for the filename — it's never /dev/null. The if/else logic is wrong in both directions:
When name1=/dev/null (new file): basename "/dev/null" → "null" ❌
When name2=/dev/null (deleted file): basename "/dev/null" → also "null" ❌
---
 git_diff_image | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/git_diff_image b/git_diff_image
index fe38723..79f3e8e 100755
--- a/git_diff_image
+++ b/git_diff_image
@@ -67,13 +67,7 @@ o_flag=''
 if [ -n "${GIT_DIFF_IMAGE_OUTPUT_DIR-}" ]
 then
     mkdir -p "$GIT_DIFF_IMAGE_OUTPUT_DIR"
-    destfile=''
-    if [ "$name1" = '/dev/null' ]
-    then
-        destfile=$(basename "$name1")
-    else
-        destfile=$(basename "$name2")
-    fi
+    destfile=$(basename "$name")
     o_flag="-o $GIT_DIFF_IMAGE_OUTPUT_DIR/$destfile"
 fi