From 6a093fb0d1d5d74783a234a1b64705c0d9df4e76 Mon Sep 17 00:00:00 2001 From: Alan Richardson Date: Sat, 25 Jul 2026 21:42:02 +0100 Subject: [PATCH] Rescue delete no-content regression tests --- .../api/docgen/ApiRoutingDefinitionDocGeneratorTest.java | 3 +++ .../restapihandlers/ThingCommandResultApiMapperTest.java | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/docgen/ApiRoutingDefinitionDocGeneratorTest.java b/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/docgen/ApiRoutingDefinitionDocGeneratorTest.java index 9070c96e..41d9bac3 100644 --- a/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/docgen/ApiRoutingDefinitionDocGeneratorTest.java +++ b/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/docgen/ApiRoutingDefinitionDocGeneratorTest.java @@ -33,6 +33,9 @@ public void entityInstanceWritesDocumentValidationAndConflictStatuses() { Assertions.assertTrue( statuses(route(definition, RoutingVerb.PUT, "todos/:id")) .containsAll(Set.of(200, 404, 422, 409))); + Assertions.assertTrue( + statuses(route(definition, RoutingVerb.DELETE, "todos/:id")) + .containsAll(Set.of(204, 404))); } @Test diff --git a/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/restapihandlers/ThingCommandResultApiMapperTest.java b/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/restapihandlers/ThingCommandResultApiMapperTest.java index 672261fb..5138c64d 100644 --- a/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/restapihandlers/ThingCommandResultApiMapperTest.java +++ b/thingifier/src/test/java/uk/co/compendiumdev/thingifier/api/restapihandlers/ThingCommandResultApiMapperTest.java @@ -96,6 +96,15 @@ public void mapsCreateValidationWithExistingLegacyPrefixBehaviour() { response.getErrorMessages()); } + @Test + public void mapsSuccessfulDeleteToNoContent() { + ApiResponse response = + mapper().map(new DeleteThingCommand("task", "1"), ThingCommandResult.success()); + + Assertions.assertEquals(204, response.getStatusCode()); + Assertions.assertFalse(response.hasABody()); + } + @Test public void mapsInstanceNotFoundWithRouteContextToLegacyPathMessage() { ThingCommandResult result =