Remove deprecated register_resource alias (clean break)

register_resource was a [[deprecated]] forwarder to register_path,
retained for migration. RELEASE_NOTES already presents it as gone
(replaced by register_path for exact match / register_prefix for prefix),
so the interim alias was the inconsistency. Remove it outright:

  - drop both overloads (templated unique_ptr + shared_ptr) from
    webserver_routes.hpp and the shared_ptr impl from webserver_register.cpp
  - webserver_register_path_prefix_test: replace the bool-family negative
    SFINAE with a clean-break pin that register_resource is gone entirely
    (no smart-pointer or bool-family overload survives); drop the
    deprecated-forwarder runtime test
  - webserver_register_smartptr_test: retarget the ownership tests
    (unique_ptr transfer, shared_ptr retention, null/duplicate throw) at
    register_path, drop the now-obsolete register_resource SFINAE
  - README: drop the "note on register_resource"; check-readme now forbids
    the register_resource identifier outright

Callers use register_path (exact) or register_prefix (prefix).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NpysYDDJac63yz2mZKKiDf

Author: etr

README.md

@@ -882,15 +882,6 @@ on the builder if you need pure literal-path semantics.
 remove a previously registered resource by path. (`unregister_resource`
 exists as a deprecated alias for `unregister_path`.)
 
-### A note on `register_resource`
-
-`register_resource(path, resource)` is a deprecated alias for
-`register_path` retained for migration convenience and marked
-`[[deprecated]]`. New code should call `register_path` for exact
-matches and `register_prefix` for subtrees.
-
-[Back to TOC](#table-of-contents)
-
 ## Request
 
 `http_request` is read-only inside a handler. The accessors are designed

scripts/check-readme.sh

@@ -105,7 +105,7 @@ V1_TOKENS_ARR=(
     '\bbasic_auth_fail_response\b'
     '\bdigest_auth_fail_response\b'
     'new[[:space:]]+[A-Za-z_]*_response[[:space:]]*\('
-    'register_resource[[:space:]]*\([^,]*,[[:space:]]*new[[:space:]]+'
+    '\bregister_resource\b'
     '\bnot_found_resource\b'
     '\bmethod_not_allowed_resource\b'
     '\binternal_error_resource\b'

src/detail/webserver_register.cpp

@@ -253,13 +253,6 @@ void webserver::register_prefix(const std::string& path,
     register_impl_(path, std::move(res), /*family=*/true);
 }
 
-// Deprecated forwarder kept for backward compatibility. Users that want
-// prefix matching must call register_prefix().
-void webserver::register_resource(const std::string& resource,
-                                  std::shared_ptr<http_resource> res) {
-    register_path(resource, std::move(res));
-}
-
 // TASK-024: erase a single registration of the requested kind (family).
 // Each kind keeps a distinct v2-table entry (parameterized routes live in
 // the radix tier, regex routes in the regex_routes_ vector, exact routes

src/httpserver/webserver.hpp

@@ -88,7 +88,7 @@ namespace httpserver {
  * threads. The thread-safety contract:
  *
  *   1. Public registration / un-registration methods (@ref register_path,
- *      @ref register_prefix, @ref register_resource, the @ref on_get
+ *      @ref register_prefix, the @ref on_get
  *      family, @ref route, @ref unregister_path, @ref unregister_prefix,
  *      @ref unregister_resource, @ref register_ws_resource,
  *      @ref unregister_ws_resource, @ref deny_ip, @ref remove_denied_ip,

src/httpserver/webserver_routes.hpp

@@ -27,8 +27,8 @@
 // Carries member-function DECLARATIONS only; meant to be included from
 // WITHIN the body of `class webserver` defined in
 // httpserver/webserver.hpp. Including it elsewhere raises a #error.
-// Covers register_path / register_prefix / register_resource (templated
-// + shared_ptr overloads), the on_* HTTP-verb shortcuts (on_get,
+// Covers register_path / register_prefix (templated + shared_ptr
+// overloads), the on_* HTTP-verb shortcuts (on_get,
 // on_post, on_put, on_delete, on_patch, on_options, on_head), the
 // table-driven route() entry points, and the matching unregister_*
 // counterparts.
@@ -127,27 +127,6 @@ void register_prefix(const std::string& path, std::unique_ptr<T> res) {
 void register_prefix(const std::string& path,
                      std::shared_ptr<http_resource> res);
 
-/**
- * Deprecated alias for register_path(). Kept for backward compatibility;
- * use register_path() for exact match or register_prefix() for prefix match.
- *
- * @param path The url pointing to the resource.
- * @param res  unique_ptr to the http_resource (or any derived type).
-**/
-template <typename T,
-          typename = std::enable_if_t<
-              std::is_base_of_v<http_resource, T>>>
-[[deprecated("use register_path() for exact match or register_prefix() for prefix match")]]
-// This file is included inside the webserver class body; transitive
-// <utility>/<memory>/<string> live in the parent webserver.hpp.
-void register_resource(const std::string& path, std::unique_ptr<T> res) {  // NOLINT(build/include_what_you_use)
-    register_path(path, std::move(res));  // NOLINT(build/include_what_you_use)
-}
-/// @copydoc register_resource(const std::string&, std::unique_ptr<T>)
-[[deprecated("use register_path() for exact match or register_prefix() for prefix match")]]
-void register_resource(const std::string& path,
-                       std::shared_ptr<http_resource> res);  // NOLINT(build/include_what_you_use)
-
 /**
  * Register a lambda handler for HTTP GET on @p path.
  *

test/Makefile.am

@@ -253,25 +253,23 @@ http_request_const_getters_LDADD =
 http_request_tls_accessors_SOURCES = unit/http_request_tls_accessors_test.cpp
 http_request_tls_accessors_LDADD =
 
-# webserver_register_smartptr: TASK-023. Compile-time signature
-# assertions that the new unique_ptr/shared_ptr register_resource
-# overloads exist and the raw-pointer overload is gone, plus runtime
-# tests for ownership semantics (unique_ptr ownership transfer,
-# shared_ptr caller-retains-ref, throw-on-null, throw-on-duplicate).
-# Default LDADD (libhttpserver + curl) is sufficient; no microhttpd
-# direct link needed.
+# webserver_register_smartptr: TASK-023. Runtime tests for the
+# register_path smart-pointer ownership semantics (unique_ptr ownership
+# transfer, shared_ptr caller-retains-ref, throw-on-null,
+# throw-on-duplicate). The compile-time signature contract lives in
+# webserver_register_path_prefix. Default LDADD (libhttpserver + curl) is
+# sufficient; no microhttpd direct link needed.
 webserver_register_smartptr_SOURCES = unit/webserver_register_smartptr_test.cpp
 
 # webserver_register_path_prefix: TASK-024. Compile-time signature
 # assertions that register_path / register_prefix exist with both
 # unique_ptr and shared_ptr overloads, that unregister_path /
-# unregister_prefix exist, and that the bool-family register_resource
-# overload has been removed (negative SFINAE pin for acceptance criterion
-# #1). Runtime tests: register_prefix matches a longer URL; register_path
-# does not; parameterized exact paths bind their args; unregister_path /
-# unregister_prefix / the umbrella unregister_resource alias all 404 the
-# route after removal; the [[deprecated]] register_resource forwarder
-# still serves and behaves like register_path.
+# unregister_prefix exist, and that register_resource has been removed
+# entirely (negative SFINAE pin — clean break; no smart-pointer or
+# bool-family overloads survive). Runtime tests: register_prefix matches a
+# longer URL; register_path does not; parameterized exact paths bind their
+# args; unregister_path / unregister_prefix / the umbrella
+# unregister_resource alias all 404 the route after removal.
 webserver_register_path_prefix_SOURCES = unit/webserver_register_path_prefix_test.cpp
 
 # webserver_on_methods: TASK-025. Compile-time signature contract for

test/unit/webserver_register_path_prefix_test.cpp

@@ -26,9 +26,9 @@
 //   - register_path(path, ptr)   -> exact match (does NOT match a longer URL)
 //   - register_prefix(path, ptr) -> prefix match (matches the path and all
 //                                   children of it)
-//   - register_resource(path, ptr) is kept as a [[deprecated]] alias for
-//     register_path so TASK-023-era call sites still compile.
-//   - The 3-arg `bool family` overloads of register_resource are gone.
+//   - register_resource is gone entirely (clean break): neither the
+//     smart-pointer overloads nor the 3-arg `bool family` overloads exist.
+//     Call register_path for exact match or register_prefix for prefix.
 //
 // This TU pins both the compile-time signature contract (the new methods
 // exist with the right shape; the bool-family overload is removed) and
@@ -150,36 +150,35 @@ static_assert(std::is_same_v<
                   void>,
               "unregister_prefix(const string&) must exist and return void");
 
-// (6) Negative SFINAE: the 3-arg bool-family overload of register_resource
-//     must be gone. (Acceptance criterion #1 of TASK-024 pinned at compile
-//     time.) The probe expression is a call with a trailing `bool` arg; if
-//     such an overload existed, the call would be well-formed and ::value
-//     would flip to true.
+// (6) Negative SFINAE: register_resource is removed entirely (clean break).
+//     None of its historical shapes may exist — the templated unique_ptr
+//     overload, the shared_ptr overload, or the 3-arg bool-family overloads.
+//     The probe covers the smart-pointer shapes (the templated/typed
+//     overloads); if any survived, the call would be well-formed and
+//     ::value would flip to true. Callers use register_path / register_prefix.
 template <typename, typename = void>
-struct has_bool_family_register : std::false_type {};
+struct has_register_resource_shared : std::false_type {};
 
 template <typename WS>
-struct has_bool_family_register<WS, std::void_t<
+struct has_register_resource_shared<WS, std::void_t<
     decltype(std::declval<WS&>().register_resource(
         std::declval<const std::string&>(),
-        std::declval<std::shared_ptr<http_resource>>(),
-        std::declval<bool>()))>> : std::true_type {};
+        std::declval<std::shared_ptr<http_resource>>()))>> : std::true_type {};
 
-static_assert(!has_bool_family_register<webserver>::value,
-              "the bool-family register_resource overload must be removed");
+static_assert(!has_register_resource_shared<webserver>::value,
+              "register_resource(const string&, shared_ptr) must be removed");
 
 template <typename, typename = void>
-struct has_bool_family_register_unique : std::false_type {};
+struct has_register_resource_unique : std::false_type {};
 
 template <typename WS>
-struct has_bool_family_register_unique<WS, std::void_t<
+struct has_register_resource_unique<WS, std::void_t<
     decltype(std::declval<WS&>().register_resource(
         std::declval<const std::string&>(),
-        std::declval<std::unique_ptr<http_resource>>(),
-        std::declval<bool>()))>> : std::true_type {};
+        std::declval<std::unique_ptr<http_resource>>()))>> : std::true_type {};
 
-static_assert(!has_bool_family_register_unique<webserver>::value,
-              "the bool-family register_resource unique_ptr overload must be removed");
+static_assert(!has_register_resource_unique<webserver>::value,
+              "register_resource(const string&, unique_ptr) must be removed");
 
 // ---- Runtime behaviour tests -------------------------------------------
 
@@ -292,26 +291,6 @@ LT_BEGIN_AUTO_TEST(webserver_register_path_prefix_suite,
     ws.stop();
 LT_END_AUTO_TEST(unregister_resource_alias_handles_both_kinds)
 
-// The deprecated register_resource(path, ptr) forwarder must still compile
-// and behave like register_path (exact match, no longer-URL match).
-// Suppress the deprecation warning locally so the test binary still
-// builds with -Werror.
-LT_BEGIN_AUTO_TEST(webserver_register_path_prefix_suite,
-                   register_resource_deprecated_forwarder_behaves_like_register_path)
-    webserver ws{create_webserver(PORT + 6)};
-#pragma GCC diagnostic push
-#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
-    ws.register_resource("/d", std::make_shared<ok_resource>());
-#pragma GCC diagnostic pop
-    ws.start(false);
-
-    LT_CHECK_EQ(fetch("localhost:8186/d").response_code, 200);
-    // Exact-match behaviour: a longer URL must 404.
-    LT_CHECK_EQ(fetch("localhost:8186/d/extra").response_code, 404);
-
-    ws.stop();
-LT_END_AUTO_TEST(register_resource_deprecated_forwarder_behaves_like_register_path)
-
 // TASK-056: registering the SAME path as both exact and prefix is no
 // longer permitted (the (method, path) cache key cannot discriminate
 // the two kinds at lookup time, so the second call now throws
@@ -525,9 +504,9 @@ LT_END_AUTO_TEST(register_prefix_unique_ptr_transfers_ownership_and_serves)
 
 // ---- Error-path tests for register_prefix (findings 9 / 32) -------------
 //
-// register_resource (deprecated alias) is tested for null / duplicate in
+// register_path is tested for null / duplicate in
 // webserver_register_smartptr_test.cpp. The tests below pin the same
-// invariants on the new register_prefix API surface so this TU is
+// invariants on the register_prefix API surface so this TU is
 // self-contained.
 
 LT_BEGIN_AUTO_TEST(webserver_register_path_prefix_suite,