Skip to content

Commit 121745b

Browse files
committed
stderr shouldnt be asserted empty
1 parent 2d2bb17 commit 121745b

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

test/ServerTest.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,16 +12,17 @@ def test_request(self):
1212
assert resp.status_code == 200
1313
with self.assertRaises(requests.ConnectionError):
1414
resp = requests.get("http://localhost:5000?oauth_verifier=%s" % test_data)
15-
15+
1616
polls = 0
1717
while serverProc.poll() is None and polls < 10:
1818
polls += 1
1919
sleep(1)
20-
21-
if serverProc.poll() is None:
20+
21+
status = serverProc.poll()
22+
if status is None:
2223
serverProc.kill()
2324
self.fail("Server process is still alive, killing now...")
24-
stdout, stderr = serverProc.communicate()
25-
26-
self.assertEqual(stderr, '', "stderr is nonempty: '%s'" % stderr)
27-
self.assertEqual(stdout, test_data, "server didnt return fake oauth verifier!")
25+
stdout, _ = serverProc.communicate()
26+
27+
self.assertEqual(0, status, "Server exited with nonzero status: %s" % status)
28+
self.assertEqual(test_data, stdout, "server didnt return fake oauth verifier!")

0 commit comments

Comments
 (0)