From 6e840eeab2dc792653edb244ccd0cab2968929b0 Mon Sep 17 00:00:00 2001
From: Cursor Agent <cursoragent@cursor.com>
Date: Mon, 24 Aug 2026 11:58:40 +0000
Subject: [PATCH] Refactor Simd::FillFrame to use Simd::Fill.

Implement the C++ wrapper with four Simd::Fill calls on View regions
instead of forwarding to SimdFillFrame. Update docs and compare the
wrapper with the C API in FillFrame tests.

Co-authored-by: igor.ermolaev <igor.ermolaev@altezza.org>
---
 docs/2026.html                |  1 +
 docs/help/group__filling.html |  4 ++--
 src/Simd/SimdLib.hpp          | 11 +++++++----
 src/Test/TestFill.cpp         |  5 +++++
 4 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/docs/2026.html b/docs/2026.html
index 39b8c90114..0c9649226e 100644
--- a/docs/2026.html
+++ b/docs/2026.html
@@ -113,6 +113,7 @@ <h5>Improving</h5>
  <li>SVE2 optimizations of function GetObjectMoments.</li>
  <li>SVE2 optimizations of function DescrIntCosineDistance.</li>
  <li>SVE2 optimizations of function DescrIntCosineDistancesMxNa.</li>
+ <li>C++ wrapper Simd::FillFrame.</li>
 </ul>
 <h5>Renaming</h5>
 <ul>
diff --git a/docs/help/group__filling.html b/docs/help/group__filling.html
index d6bf1016cb..c683028cbf 100644
--- a/docs/help/group__filling.html
+++ b/docs/help/group__filling.html
@@ -593,8 +593,8 @@ <h2 class="memtitle"><span class="permalink"><a href="#gac5ce7e9dbe4a739162d1279
 </div><div class="memdoc">
 
 <p>Fills image pixel data outside of the given inner frame with the given 8-bit value. </p>
-<p >The function fills four areas: rows above frame.top, rows at or below frame.bottom, columns before frame.left inside the frame vertical range, and columns at or after frame.right inside the frame vertical range. The rectangle [<em>frame.left</em>, <em>frame.right</em>) x [<em>frame.top</em>, <em>frame.bottom</em>) is left unchanged. <a class="el" href="struct_simd_1_1_frame.html" title="The Frame structure provides storage and manipulation of frames (multiplanar images).">Frame</a> coordinates must satisfy 0 &lt;= frame.left &lt;= frame.right &lt;= dst.width and 0 &lt;= frame.top &lt;= frame.bottom &lt;= dst.height.</p>
-<dl class="section note"><dt>Note</dt><dd>This function is a C++ wrapper for function <a class="el" href="group__filling.html#ga91f666d797f0157ca963d4c6fe4837c9" title="Fills image pixel data outside of the given inner frame with the given 8-bit value.">SimdFillFrame</a>.</dd></dl>
+<p >The function fills four areas by calling Simd::Fill for the corresponding image regions: rows above frame.top, rows at or below frame.bottom, columns before frame.left inside the frame vertical range, and columns at or after frame.right inside the frame vertical range. The rectangle [<em>frame.left</em>, <em>frame.right</em>) x [<em>frame.top</em>, <em>frame.bottom</em>) is left unchanged. <a class="el" href="struct_simd_1_1_frame.html" title="The Frame structure provides storage and manipulation of frames (multiplanar images).">Frame</a> coordinates must satisfy 0 &lt;= frame.left &lt;= frame.right &lt;= dst.width and 0 &lt;= frame.top &lt;= frame.bottom &lt;= dst.height.</p>
+<dl class="section note"><dt>Note</dt><dd>This function is implemented on the base of function <a class="el" href="group__filling.html#ga54fc3ed63731c6f0528a1ce9ac86b2a1" title="Fills every byte of image pixel data with the given 8-bit value.">Fill</a>.</dd></dl>
 <dl class="params"><dt>Parameters</dt><dd>
   <table class="params">
     <tr><td class="paramdir">[out]</td><td class="paramname">dst</td><td>- a destination image. </td></tr>
diff --git a/src/Simd/SimdLib.hpp b/src/Simd/SimdLib.hpp
index adc2daa404..ff1106a432 100644
--- a/src/Simd/SimdLib.hpp
+++ b/src/Simd/SimdLib.hpp
@@ -1958,13 +1958,14 @@ namespace Simd
 
         \short Fills image pixel data outside of the given inner frame with the given 8-bit value.
 
-        The function fills four areas: rows above frame.top, rows at or below frame.bottom, columns before
+        The function fills four areas by calling Simd::Fill for the corresponding image regions:
+        rows above frame.top, rows at or below frame.bottom, columns before
         frame.left inside the frame vertical range, and columns at or after frame.right inside the frame vertical range.
         The rectangle [\a frame.left, \a frame.right) x [\a frame.top, \a frame.bottom) is left unchanged.
         Frame coordinates must satisfy 0 <= frame.left <= frame.right <= dst.width and
         0 <= frame.top <= frame.bottom <= dst.height.
 
-        \note This function is a C++ wrapper for function ::SimdFillFrame.
+        \note This function is implemented on the base of function Simd::Fill.
 
         \param [out] dst - a destination image.
         \param [in] frame - a rectangle defining the untouched interior region.
@@ -1972,8 +1973,10 @@ namespace Simd
     */
     template<template<class> class A> SIMD_INLINE void FillFrame(View<A>& dst, const Rectangle<ptrdiff_t> & frame, uint8_t value)
     {
-        SimdFillFrame(dst.data, dst.stride, dst.width, dst.height, dst.PixelSize(),
-            frame.left, frame.top, frame.right, frame.bottom, value);
+        Fill(dst.Region(0, 0, dst.width, frame.top).Ref(), value);
+        Fill(dst.Region(0, frame.bottom, dst.width, dst.height).Ref(), value);
+        Fill(dst.Region(0, frame.top, frame.left, frame.bottom).Ref(), value);
+        Fill(dst.Region(frame.right, frame.top, dst.width, frame.bottom).Ref(), value);
     }
 
     /*! @ingroup filling
diff --git a/src/Test/TestFill.cpp b/src/Test/TestFill.cpp
index 3534b0e5d7..92c7181c2f 100644
--- a/src/Test/TestFill.cpp
+++ b/src/Test/TestFill.cpp
@@ -147,6 +147,11 @@ namespace Test
 
         result = result && Compare(d1, d2, 0, true, 32);
 
+        View d3(width, height, format, NULL, TEST_ALIGN(width));
+        Simd::Fill(d3, 0);
+        Simd::FillFrame(d3, frame, value);
+        result = result && Compare(d1, d3, 0, true, 32);
+
         return result;
     }