From 4ad477d55ee1eae7b799d8e9864e1e3ee7618905 Mon Sep 17 00:00:00 2001 From: paul <423357+toothbrush@users.noreply.github.com> Date: Thu, 8 Oct 2026 16:04:22 +0930 Subject: [PATCH 1/2] build(git-remote-entire): stamp commit into per-commit builds The per-commit publish left Version unstamped, so versioninfo.Load() picked up the workflow's throwaway v0.0.0 tag from Go build info and every runner/Buildkite helper reported "git-remote-entire/0.0.0". Stamp Version=0.0.0+ so the User-Agent and git agent= capability identify the commit. Tagged releases are unchanged. Co-Authored-By: Claude Mythos 5.1 --- .github/workflows/publish-git-remote-entire.yml | 5 +++-- .goreleaser.nonprod.yaml | 10 +++++++--- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/publish-git-remote-entire.yml b/.github/workflows/publish-git-remote-entire.yml index d5e19be8a7..8ed318ced2 100644 --- a/.github/workflows/publish-git-remote-entire.yml +++ b/.github/workflows/publish-git-remote-entire.yml @@ -32,8 +32,9 @@ jobs: go-version-file: go.mod # GoReleaser refuses to run untagged. The tag is local to the - # runner, never pushed, and deliberately not stamped into the - # binary (see the ldflags note in .goreleaser.nonprod.yaml). + # runner and never pushed. The binary's Version is stamped as + # 0.0.0+ by the ldflags in .goreleaser.nonprod.yaml, so the + # tag never reaches the User-Agent. - name: Make a throwaway tag run: git tag --force v0.0.0 diff --git a/.goreleaser.nonprod.yaml b/.goreleaser.nonprod.yaml index 5e555c0388..5f9fb77aa1 100644 --- a/.goreleaser.nonprod.yaml +++ b/.goreleaser.nonprod.yaml @@ -29,9 +29,13 @@ builds: - arm64 ldflags: - -s -w - # No Version stamp: the workflow's throwaway v0.0.0 tag would be - # stamped verbatim. versioninfo.Load() falls back to build info, - # so the binary still self-reports the commit it was built from. + # Stamp the commit into Version. Without it, versioninfo.Load() + # reads the workflow's throwaway v0.0.0 tag from build info and + # every per-commit build reports "git-remote-entire/0.0.0". + # Must stay a single token: it rides in the HTTP User-Agent and + # the git agent= capability. "+sha" is semver build metadata, so + # versioncheck treats it as a dev build. + - -X github.com/entireio/cli/cmd/entire/cli/versioninfo.Version=0.0.0+{{.ShortCommit}} - -X github.com/entireio/cli/cmd/entire/cli/versioninfo.Commit={{.ShortCommit}} archives: From 56223ddd0be45ac3aa5c212ae5e401ac2fbca546 Mon Sep 17 00:00:00 2001 From: paul <423357+toothbrush@users.noreply.github.com> Date: Sat, 10 Oct 2026 10:25:52 +0930 Subject: [PATCH 2/2] build(git-remote-entire): stamp the full commit, drop the comments Co-Authored-By: Claude Mythos 5.1 --- .github/workflows/publish-git-remote-entire.yml | 4 +--- .goreleaser.nonprod.yaml | 8 +------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/publish-git-remote-entire.yml b/.github/workflows/publish-git-remote-entire.yml index 8ed318ced2..f5dfc57b4e 100644 --- a/.github/workflows/publish-git-remote-entire.yml +++ b/.github/workflows/publish-git-remote-entire.yml @@ -32,9 +32,7 @@ jobs: go-version-file: go.mod # GoReleaser refuses to run untagged. The tag is local to the - # runner and never pushed. The binary's Version is stamped as - # 0.0.0+ by the ldflags in .goreleaser.nonprod.yaml, so the - # tag never reaches the User-Agent. + # runner and never pushed. - name: Make a throwaway tag run: git tag --force v0.0.0 diff --git a/.goreleaser.nonprod.yaml b/.goreleaser.nonprod.yaml index 5f9fb77aa1..d38f4e4784 100644 --- a/.goreleaser.nonprod.yaml +++ b/.goreleaser.nonprod.yaml @@ -29,13 +29,7 @@ builds: - arm64 ldflags: - -s -w - # Stamp the commit into Version. Without it, versioninfo.Load() - # reads the workflow's throwaway v0.0.0 tag from build info and - # every per-commit build reports "git-remote-entire/0.0.0". - # Must stay a single token: it rides in the HTTP User-Agent and - # the git agent= capability. "+sha" is semver build metadata, so - # versioncheck treats it as a dev build. - - -X github.com/entireio/cli/cmd/entire/cli/versioninfo.Version=0.0.0+{{.ShortCommit}} + - -X github.com/entireio/cli/cmd/entire/cli/versioninfo.Version=0.0.0+{{.FullCommit}} - -X github.com/entireio/cli/cmd/entire/cli/versioninfo.Commit={{.ShortCommit}} archives: