From 4cd9accd9cb74435fa00a0e0a50baa7818430fb5 Mon Sep 17 00:00:00 2001 From: Sarah Michels Date: Wed, 29 Jul 2026 10:44:04 -0700 Subject: [PATCH] fix(ci): check pecl exit code after yes pipe closes yes exits 1 (not 141) on broken pipe in GitHub Actions, so the prior SIGPIPE guard still failed the step after a successful pecl install. Disable pipefail for the pipe and fail only when pecl returns non-zero. Co-authored-by: Cursor --- .github/actions/install-valkey-glide/action.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/actions/install-valkey-glide/action.yml b/.github/actions/install-valkey-glide/action.yml index 77cd9b9..71090d6 100644 --- a/.github/actions/install-valkey-glide/action.yml +++ b/.github/actions/install-valkey-glide/action.yml @@ -46,6 +46,12 @@ runs: export PATH="$HOME/.cargo/bin:$PATH" curl -fsSL -o /tmp/valkey_glide.tgz \ "https://github.com/valkey-io/valkey-glide-php/releases/download/v${{ inputs.version }}/valkey_glide-${{ inputs.version }}.tgz" - yes '' | sudo env HOME="$HOME" CARGO_HOME="$HOME/.cargo" PATH="$PATH" pecl install /tmp/valkey_glide.tgz || [[ $? -eq 141 ]] + set +o pipefail + yes '' | sudo env HOME="$HOME" CARGO_HOME="$HOME/.cargo" PATH="$PATH" pecl install /tmp/valkey_glide.tgz + pecl_exit=${PIPESTATUS[1]} + set -o pipefail + if [[ "${pecl_exit}" -ne 0 ]]; then + exit "${pecl_exit}" + fi echo "extension=valkey_glide.so" | sudo tee "$(php -r 'echo PHP_CONFIG_FILE_SCAN_DIR;')/99-valkey_glide.ini" rm -f /tmp/valkey_glide.tgz