GET parameters are no longer merged in 0.28.0

[yan12125]

#3364 changes how GET parameters are handled. For this example script:

import json
import httpx

print(json.dumps(httpx.get("https://httpbin.org/get?foo=bar", params={}).json()))

Results before the PR:

$ python t.py | jq .args
{
  "foo": "bar"
}

And after the PR:

$ python t.py | jq .args
{}

Is that an intentional change? If so, maybe documenting it in changelogs is better.

[lovelydinosaur]

Is that an intentional change? If so, maybe documenting it in changelogs is better.

Yep, I think you've got the right take there. My recollection is that I noticed that the simpler refactoring would also fix a bug along the way, tho then forgot to point that out by the time I came to issue the refactoring. Unfortunately we didn't happen to have a test case covering this.

https://github.com/encode/httpx/issues/3433#issuecomment-2514327255

PRs updating the CHANGELOG there would be welcome. (Possibly also including related tests)

[eliasdorneles]

I see that the change is documented in the changelog file but not in the Github Release.
A friend and I spent sometime debugging our broken tests, until we realized there was this change.

@tomchristie could we have the Github Release updated to match the contents of changelog section? 👼
Thank you so much! ❤️

[lovelydinosaur]

Thanks @eliasdorneles, I've fixed up the release notes now. 😌