diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/workflows/PULL_REQUEST_TEMPLATE/pull_request_template.md index 3fe9753b..680f9527 100644 --- a/.github/workflows/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/workflows/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -12,6 +12,10 @@ - [ ] Step1 - [ ] Step2 +### Accessibility + +- This meets the [Accessibility](https://www.notion.so/fourkitchens/ENG-Best-Practice-Accessibility-Policy-9576a65b905243a1acbc4bd8ac989794?source=copy_link) best practices + **Closes issues** diff --git a/.github/workflows/deploy-to-gh-pages.yml b/.github/workflows/deploy-to-gh-pages.yml index e763f0ad..fbb1dafd 100644 --- a/.github/workflows/deploy-to-gh-pages.yml +++ b/.github/workflows/deploy-to-gh-pages.yml @@ -13,8 +13,6 @@ permissions: contents: read pages: write id-token: write - packages: write - repository-projects: read # Allow one concurrent deployment concurrency: @@ -27,37 +25,25 @@ jobs: runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v3 - - name: Detect package manager - id: detect-package-manager - run: | - if [ -f "${{ github.workspace }}/yarn.lock" ]; then - echo "manager=yarn" >> $GITHUB_OUTPUT - echo "command=install" >> $GITHUB_OUTPUT - echo "runner=yarn" >> $GITHUB_OUTPUT - exit 0 - elif [ -f "${{ github.workspace }}/package.json" ]; then - echo "manager=npm" >> $GITHUB_OUTPUT - echo "command=ci" >> $GITHUB_OUTPUT - echo "runner=npx --no-install" >> $GITHUB_OUTPUT - exit 0 - else - echo "Unable to determine packager manager" - exit 1 - fi + uses: actions/checkout@v4 + - name: Setup Node - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: 20 - cache: ${{ steps.detect-package-manager.outputs.manager }} + node-version-file: .nvmrc + cache: npm + - name: Setup Pages - uses: actions/configure-pages@v3 + uses: actions/configure-pages@v5 + - name: Install dependencies - run: ${{ steps.detect-package-manager.outputs.manager }} ${{ steps.detect-package-manager.outputs.command }} + run: npm ci + - name: Build Storybook run: npm run storybook-build + - name: Upload artifact - uses: actions/upload-pages-artifact@v1 + uses: actions/upload-pages-artifact@v3 with: path: .out @@ -71,4 +57,4 @@ jobs: steps: - name: Deploy to GitHub Pages id: deployment - uses: actions/deploy-pages@v1 + uses: actions/deploy-pages@v4 \ No newline at end of file diff --git a/.gitignore b/.gitignore index f9b987df..b846e832 100644 --- a/.gitignore +++ b/.gitignore @@ -21,6 +21,7 @@ lib-cov # Coverage directory used by tools like istanbul coverage *.lcov +config/.coverage/ # nyc test coverage .nyc_output