Bump elixir sense (#657)

* complete bitstring options

* add trigger charakter

* bump elixir_sense

bring in fixes and complete improvements

Author: lukaszsamson

apps/language_server/lib/language_server/providers/completion.ex

@@ -79,8 +79,9 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
 
   def trigger_characters do
     # VS Code's 24x7 autocompletion triggers automatically on alphanumeric characters. We add these
-    # for "SomeModule." calls, @module_attrs, function capture, variable pinning, erlang module calls
-    [".", "@", "&", "%", "^", ":", "!"]
+    # for "SomeModule." calls, @module_attrs, function capture, variable pinning, erlang module calls,
+    # bitstring options and sigils
+    [".", "@", "&", "%", "^", ":", "!", "-", "~"]
   end
 
   def completion(text, line, character, options) do
@@ -452,6 +453,30 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
     }
   end
 
+  defp from_completion_item(
+         %{type: :bitstring_option, name: name},
+         _context,
+         options
+       ) do
+    insert_text =
+      case name do
+        name when name in ["size", "unit"] ->
+          function_snippet(name, ["integer"], 1, options |> Keyword.merge(with_parens?: true))
+
+        other ->
+          other
+      end
+
+    %__MODULE__{
+      label: name,
+      detail: "bitstring option",
+      insert_text: insert_text,
+      priority: 10,
+      kind: :type_parameter,
+      tags: []
+    }
+  end
+
   defp from_completion_item(
          %{type: :type_spec, metadata: metadata} = suggestion,
          _context,
@@ -771,10 +796,9 @@ defmodule ElixirLS.LanguageServer.Providers.Completion do
 
     {label, insert_text} =
       cond do
-        match?("sigil_" <> _, name) ->
-          "sigil_" <> sigil_name = name
-          text = "~#{sigil_name}"
-          {text, text}
+        match?("~" <> _, name) ->
+          "~" <> sigil_name = name
+          {name, sigil_name}
 
         use_name_only?(origin, name) or String.starts_with?(text_after_cursor, "(") ->
           {name, name}

apps/language_server/test/providers/completion_test.exs

@@ -437,12 +437,12 @@ defmodule ElixirLS.LanguageServer.Providers.CompletionTest do
 
         def dummy_function(var = %MyModule{}) do
           %{var |
-          #      ^
+          #       ^
         end
       end
       """
 
-      {line, char} = {4, 11}
+      {line, char} = {4, 12}
       TestUtils.assert_has_cursor_char(text, line, char)
       {:ok, %{"items" => items}} = Completion.completion(text, line, char, @supports)
 
@@ -457,12 +457,12 @@ defmodule ElixirLS.LanguageServer.Providers.CompletionTest do
       defmodule MyModule do
         def dummy_function(var = %{some: nil, other: 1}) do
           %{var |
-          #      ^
+          #       ^
         end
       end
       """
 
-      {line, char} = {2, 11}
+      {line, char} = {2, 12}
       TestUtils.assert_has_cursor_char(text, line, char)
       {:ok, %{"items" => items}} = Completion.completion(text, line, char, @supports)
 

mix.lock

@@ -1,7 +1,7 @@
 %{
   "dialyxir": {:hex, :dialyxir, "1.1.0", "c5aab0d6e71e5522e77beff7ba9e08f8e02bad90dfbeffae60eaf0cb47e29488", [:mix], [{:erlex, ">= 0.2.6", [hex: :erlex, repo: "hexpm", optional: false]}], "hexpm", "07ea8e49c45f15264ebe6d5b93799d4dd56a44036cf42d0ad9c960bc266c0b9a"},
   "docsh": {:hex, :docsh, "0.7.2", "f893d5317a0e14269dd7fe79cf95fb6b9ba23513da0480ec6e77c73221cae4f2", [:rebar3], [{:providers, "1.8.1", [hex: :providers, repo: "hexpm", optional: false]}], "hexpm", "4e7db461bb07540d2bc3d366b8513f0197712d0495bb85744f367d3815076134"},
-  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "3aff3709d78f79c641fc0df47b0976aa7217b45e", []},
+  "elixir_sense": {:git, "https://github.com/elixir-lsp/elixir_sense.git", "33df514a1254455f54cb069999454c7e8586eb2d", []},
   "erl2ex": {:git, "https://github.com/dazuma/erl2ex.git", "244c2d9ed5805ef4855a491d8616b8842fef7ca4", []},
   "erlex": {:hex, :erlex, "0.2.6", "c7987d15e899c7a2f34f5420d2a2ea0d659682c06ac607572df55a43753aa12e", [:mix], [], "hexpm", "2ed2e25711feb44d52b17d2780eabf998452f6efda104877a3881c2f8c0c0c75"},
   "getopt": {:hex, :getopt, "1.0.1", "c73a9fa687b217f2ff79f68a3b637711bb1936e712b521d8ce466b29cbf7808a", [:rebar3], [], "hexpm", "53e1ab83b9ceb65c9672d3e7a35b8092e9bdc9b3ee80721471a161c10c59959c"},