Desloppify: deduplicate 9 boilerplate blocks across queries, validators, timeline components

[elfensky]

Surfaced by desloppify scan. The boilerplate_duplication detector found 9 repeated code blocks (7-15 line windows).

Findings

src/db/queries/ (4 findings — auth-guard / start-timer boilerplate)

Files
src/db/queries/api.mjs:17 + src/features/archives/reseedSeason.mjs:34 (7 lines)
src/db/queries/api.mjs:59 + src/features/archives/reseedSeason.mjs:34 (7 lines)
src/db/queries/account.mjs:57 + src/db/queries/api.mjs:59 (11 lines)
src/db/queries/account.mjs:13 + src/db/queries/api.mjs:17 (8 lines)

Suggested helper: a shared requireAuth() / withTiming() wrapper for query-layer functions. See CLAUDE.md § Error Handling — the project already has tryCatch; an auth-guard companion would slot in cleanly.

src/db/queries/admin.mjs (1 finding)

Files
src/db/queries/admin.mjs:183 + src/db/queries/api.mjs:36 (15 lines)

Validators (1 finding)

Files
src/validators/isValidSeason.mjs:43 + src/validators/isValidStatus.mjs:25 (11 lines)

Upsert helpers (1 finding)

Files
src/db/queries/upsertStatistic.mjs:25 + src/db/queries/upsertStatus.mjs:19 (8 lines)

Timeline components (1 finding)

Files
src/features/timeline/CascadeLog.jsx:30 + src/features/timeline/EventLog.jsx:47 (8 lines)

Galaxy event cards (1 finding)

Files
src/features/galaxy/DefeatedCard.jsx:47 + src/features/galaxy/EventCard.jsx:191 (12 lines)

Action

• DB query boilerplate is the highest-leverage cluster (5 findings, all auth-guard / timing pattern). Extract a single helper.
• Validator + upsert duplication is small but mechanical — share a tiny helper.
• Component duplication (CascadeLog/EventLog, DefeatedCard/EventCard) — judgment call: pull out a shared sub-component if the shape is genuinely the same.

Detector: boilerplate_duplication · Tier T3

🤖 Filed by /desloppify

[elfensky]

Partial progress — 4 of 9 boilerplate blocks closed by PR #407 (auth-helpers extraction, released as 0.51.1 on develop).

Closed (auth-guard cluster)

All four were variants of the inlined if (!auth) → session check → ownership check pattern, now consolidated into requireSession() / requireUser() / requireAdmin() in src/shared/utils/api/authGuards.mjs:

• ✅ src/db/queries/api.mjs:17 + src/features/archives/reseedSeason.mjs:34 (7 lines)
• ✅ src/db/queries/api.mjs:59 + src/features/archives/reseedSeason.mjs:34 (7 lines)
• ✅ src/db/queries/account.mjs:57 + src/db/queries/api.mjs:59 (11 lines)
• ✅ src/db/queries/account.mjs:13 + src/db/queries/api.mjs:17 (8 lines)

Note: src/db/queries/admin.mjs, api.mjs, and account.mjs no longer exist — they moved/consolidated into src/features/admin/actions.mjs and src/features/account/actions.mjs in PR #411 (0.51.5).

Remaining (5 blocks)

• src/db/queries/admin.mjs:183 + src/db/queries/api.mjs:36 (15 lines) — may have dissolved when those files moved/consolidated in PR refactor: split src/db/queries/ by responsibility — close #406 cluster #411; needs a fresh desloppify scan to confirm
• src/validators/isValidSeason.mjs:43 + src/validators/isValidStatus.mjs:25 (11 lines) — PR refactor(validators): unify on direct-export shape across all 5 isValid* files #412 (validator-protocol-unification) addressed export shape, not the internal eventSchema / campaignStatusSchema duplication
• src/db/queries/upsertStatistic.mjs:25 + src/db/queries/upsertStatus.mjs:19 (8 lines) — not addressed
• src/features/timeline/CascadeLog.jsx:30 + src/features/timeline/EventLog.jsx:47 (8 lines) — not addressed
• src/features/galaxy/DefeatedCard.jsx:47 + src/features/galaxy/EventCard.jsx:191 (12 lines) — not addressed

Keep open. Recommend rescan before next pass to confirm which still apply.

[elfensky]

Closing as stale — the referenced files (src/db/queries/api.mjs, account.mjs) were removed/reorganized in the db-queries/actions split refactor; the auth-guard/timing boilerplate this issue targeted no longer exists in that form.