Grid View#59
Conversation
|
This is pretty major redesign that I think needs to be split into a number of smaller branches. I'll leave a more thorough review later but I don't have the time at the moment sorry |
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
Part of me feels like symbolic mode could just be a toggle instead of a single item in a menu. Another part of me also feels like it would be good to be able to toggle symbolic mode from within the dialog as well. Just thoughts, I am no UX expert 😅
| 'src/Services/Collection.vala', | ||
| 'src/Widgets/IconListChild.vala', | ||
| 'src/Widgets/SidebarRow.vala', | ||
| 'src/Dialogs/IconView.vala', |
There was a problem hiding this comment.
Don't think it is a rule but it seems like we try to keep the source file listing in alpha order, so I wold move this up
| @@ -0,0 +1,2368 @@ | |||
| /* | |||
| * SPDX-License-Identifier: GPL-3.0-or-later | |||
| * SPDX-FileCopyrightText: 2017-2022 elementary, Inc. (https://elementary.io) | |||
There was a problem hiding this comment.
| * SPDX-FileCopyrightText: 2017-2022 elementary, Inc. (https://elementary.io) | |
| * SPDX-FileCopyrightText: 2017-2024 elementary, Inc. (https://elementary.io) |
| wrap = true, | ||
| xalign = 0, | ||
| valign = Gtk.Align.END | ||
| var title_label = new Gtk.Label ("<b>%s</b>".printf (icon_name)) { |
There was a problem hiding this comment.
Does the Granite class added to this not make the title bold?
| source_view.add_css_class (Granite.STYLE_CLASS_SMALL_LABEL); | ||
|
|
||
| copy_button = new Gtk.Button.with_label (_("Copy")) { | ||
| copy_button = new Gtk.Button.from_icon_name ("edit-copy-symbolic") { |
There was a problem hiding this comment.
If it isn't going to have the label I would give it a tooltip
|
I understand, it's a big change, but it could be reviewed little by little and come to a better agreement on design and UX, it's not a priority for now. |
It is valid, however, the search could be improved, as there are some icons that are only symbolic.
|
|
Yeah maybe the main view should always show both and the search should have a filter to toggle all | color | symbolic ? |
3 participants
Close: #58
Demo
Screencast.from.2024-09-17.05-03-57.mp4