Commit 80325bf
authored
karpenter: clarify createServiceAccount semantics in docs, schema, and runtime log (#8720)
The karpenter.createServiceAccount flag controls which component
creates the 'karpenter' service account (eksctl vs the Karpenter
Helm chart), not whether a service account is created. A SA always
ends up on the cluster either way. The previous docs ("create a
service account or not") and silent log output for the true case
made this confusing.
This change:
- Rewrites the CreateServiceAccount struct-field comment in
pkg/apis/eksctl.io/v1alpha5/types.go to describe the actual
behavior, and regenerates schema.json.
- Adds a dedicated 'createServiceAccount' subsection to
userdocs/src/usage/eksctl-karpenter.md explaining both modes.
- Adds Info-level log output at runtime so eksctl reports which
component will create the SA.
No behavior changes.1 parent 59d2475 commit 80325bf
4 files changed
Lines changed: 38 additions & 4 deletions
File tree
- pkg
- actions/karpenter
- apis/eksctl.io/v1alpha5
- assets
- userdocs/src/usage
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
63 | 66 | | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
64 | 70 | | |
65 | 71 | | |
66 | 72 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1549 | 1549 | | |
1550 | 1550 | | |
1551 | 1551 | | |
1552 | | - | |
1553 | | - | |
| 1552 | + | |
| 1553 | + | |
1554 | 1554 | | |
1555 | 1555 | | |
1556 | 1556 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1136 | 1136 | | |
1137 | 1137 | | |
1138 | 1138 | | |
1139 | | - | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
1140 | 1149 | | |
1141 | 1150 | | |
1142 | 1151 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
35 | 35 | | |
36 | 36 | | |
37 | 37 | | |
38 | | - | |
| 38 | + | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
43 | 62 | | |
44 | 63 | | |
45 | 64 | | |
| |||
0 commit comments