[Tooling] ESLint config has no TypeScript-specific rules — `no-floating-promises`, `strict-boolean-expressions` are missing

[cybermax4200]

Why this matters now: .eslintrc.js extends @react-native which includes basic React Native rules but no @typescript-eslint/* rules. This means unchecked promise rejections (no-floating-promises), unsafe boolean coercions, and other TypeScript-specific anti-patterns are invisible to the linter. The codebase already has several instances of unchecked async calls (e.g., authenticate(publicKey).catch(() => {}) in OnboardingScreen.tsx:33).

Problem / What: .eslintrc.js — extends @react-native only. No plugin:@typescript-eslint/recommended or plugin:@typescript-eslint/stylistic. Missing rules:

• @typescript-eslint/no-floating-promises — catches unhandled promise rejections.
• @typescript-eslint/strict-boolean-expressions — prevents implicit truthy checks on non-boolean values.
• @typescript-eslint/no-misused-promises — prevents passing async functions where sync is expected.
• @typescript-eslint/await-thenable — catches await on non-thenables.

Key Challenges:

• Add plugin:@typescript-eslint/recommended and plugin:@typescript-eslint/stylistic to extends.
• Fix all resulting lint errors (there will be many — the codebase has numerous unchecked promises and any-typed boolean checks).
• no-floating-promises will flag every authenticate(...).catch(...) pattern and every unhandled submitProof(...) call.
• This is a cross-cutting change that touches most files.

Acceptance Criteria:

• ESLint config includes @typescript-eslint/recommended and @typescript-eslint/stylistic.
• no-floating-promises is enabled (at minimum as warning).
• All resulting lint errors are fixed (not suppressed with // eslint-disable).
• npm run lint passes cleanly.
• CI enforces lint (if CI is set up per issue CI pipeline has no TypeScript check, coverage gate, or bundle size tracking #17).

Relevant files/functions:

• .eslintrc.js
• All source files (lint errors will surface across the codebase)

Out of scope: Prettier config changes, import ordering rules.

Labels: tooling, advanced, quality

[xJeffx23]

Hi! My name is Jefferson. I’m a Software Engineering student with experience in TypeScript, React Native, JavaScript, and open-source development. I’ve contributed to multiple open-source projects and have experience working with existing codebases, debugging issues, improving code quality, and maintaining TypeScript applications.

I’d be interested in taking on this issue. I understand that the main goal is to introduce stronger TypeScript-specific ESLint rules, particularly around promise handling, boolean expressions, and async functions, and then systematically fix the resulting issues across the codebase rather than suppressing them.

My approach would be to first review the current ESLint and TypeScript configuration and establish a baseline with the existing lint results. Then I’d introduce the recommended TypeScript rules, categorize the resulting errors, and fix them according to the actual intent of each piece of code, especially for unchecked promises and async handlers. Finally, I’d run the complete lint suite and verify that CI remains clean.

I’d be happy to take ownership of the issue and work through the changes systematically.

Would it be possible to assign this issue to me?

Thanks!

[ayomidearegbeshola29-dev]

I’d like to take this on. I’m comfortable working with TypeScript/React Native codebases and understand that adding the TypeScript ESLint recommended and stylistic rules is a cross-cutting change rather than a simple ESLint configuration update.

I’ll first audit the existing .eslintrc.js, TypeScript configuration, and current lint setup, then enable @typescript-eslint/recommended and @typescript-eslint/stylistic with the appropriate parser/plugin configuration. I’ll specifically enable @typescript-eslint/no-floating-promises, strict-boolean-expressions, no-misused-promises, and await-thenable, with the severity documented so the project has a clear enforcement policy.

After enabling the rules, I’ll work through the resulting violations across the codebase instead of suppressing them. This will include handling unchecked async operations such as authenticate(...).catch(...), ensuring promise-returning functions are handled explicitly, correcting unsafe truthy/falsy checks, and fixing async callbacks passed to APIs that expect synchronous functions. Where a rule exposes an intentional pattern, I’ll refactor it into an explicit and type-safe form rather than adding blanket eslint disables.

I’ll keep the change focused on TypeScript linting and will not modify Prettier or import-order configuration. I’ll also verify that the existing React Native rules continue to work correctly, run npm run lint until the project is clean, and run the relevant TypeScript checks/tests to catch issues introduced by the refactors. If CI is available, I’ll ensure the lint command is suitable for enforcement there as well.

[grantfox-oss]

🦊 GrantFox — @xJeffx23 has been assigned to this issue as part of the Third Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #93)
2. Your PR will be reviewed by the ecotask-network maintainers

Good luck! Track your progress on GrantFox.

[grantfox-oss]

🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!

@xJeffx23's PR #105 was approved and merged by @cybermax4200.

🏆 @xJeffx23: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (882 total points). Track your full progress on GrantFox.

👏 Great work, @xJeffx23! Keep contributing to ecotask-network.