From 7127ee59d1d4c41d7f5e74e10722f79f124a95d6 Mon Sep 17 00:00:00 2001 From: delchev Date: Sun, 16 Aug 2026 12:30:40 +0300 Subject: [PATCH] test(monitoring): the build assertion names the configured product MonitoringShellIT asserted that the sidebar's build line contains the literal "Eclipse Dirigible". That element is rendered from DIRIGIBLE_PRODUCT_NAME via /services/core/version, so a rebranded assembly correctly names its own build there and the assertion can never hold for it. This matters because tests-integrations lives in src/main precisely so the jar publishes and downstream editions can reuse these ITs; the codbex editions run MonitoringShellIT through a @Suite, where it has been failing on every build. Assert the configured product name instead. Stock CI is unchanged - project.title is "Eclipse Dirigible" in the root pom and is filtered into build/application's dirigible.properties, so the expected text is the same literal as before. Co-Authored-By: Claude Opus 5 --- .../tests/ui/tests/MonitoringShellIT.java | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/tests/tests-integrations/src/main/java/org/eclipse/dirigible/integration/tests/ui/tests/MonitoringShellIT.java b/tests/tests-integrations/src/main/java/org/eclipse/dirigible/integration/tests/ui/tests/MonitoringShellIT.java index 572f7a0b3b7..aa872a8b1dd 100644 --- a/tests/tests-integrations/src/main/java/org/eclipse/dirigible/integration/tests/ui/tests/MonitoringShellIT.java +++ b/tests/tests-integrations/src/main/java/org/eclipse/dirigible/integration/tests/ui/tests/MonitoringShellIT.java @@ -9,6 +9,7 @@ */ package org.eclipse.dirigible.integration.tests.ui.tests; +import org.eclipse.dirigible.commons.config.Configuration; import org.eclipse.dirigible.tests.base.UserInterfaceIntegrationTest; import org.eclipse.dirigible.tests.framework.browser.HtmlElementType; import org.junit.jupiter.api.Test; @@ -32,6 +33,11 @@ public class MonitoringShellIT extends UserInterfaceIntegrationTest { private static final String MONITORING_PATH = "/services/web/monitoring/index.html"; + /** + * The configuration key the version endpoint - and therefore the sidebar - reports as the product. + */ + private static final String DIRIGIBLE_PRODUCT_NAME = "DIRIGIBLE_PRODUCT_NAME"; + @Test void overviewRendersTheInstanceState() { ide.openPath(MONITORING_PATH); @@ -69,8 +75,11 @@ void systemNamesTheDeployedBuild() { browser.clickOnElementById("monitoring-nav-system"); browser.assertElementExistsByIdAndContainsText("monitoring-system-version", "Product"); browser.assertElementExistsByIdAndContainsText("monitoring-system-version", "Version"); - // The same figures condensed onto the sidebar, where every page shows them. - browser.assertElementExistsByIdAndContainsText("monitoring-build", "Eclipse Dirigible"); + // The same figures condensed onto the sidebar, where every page shows them. The expected name is + // read from the configuration the sidebar itself renders, not hard-coded: this IT ships in + // dirigible-tests-integrations for downstream editions to reuse, and a rebranded assembly names + // its own build here - hard-coding "Eclipse Dirigible" made the test unpassable for them. + browser.assertElementExistsByIdAndContainsText("monitoring-build", Configuration.get(DIRIGIBLE_PRODUCT_NAME)); } /**