Skip to content

setup.py does not properly pull in requirements because it imports things that it shouldn't #1

Description

@fiendish

pip install git+https://github.com/eDIMESLab/MedicalImageAnonymizer or pip install . in a clone should install necessary requirements for you if setup.py is well constructed, but it doesn't.

The problem is that your setup.py in

from MedicalImageAnonymizer.build import get_requires
invokes MedicalImageAnonymizer.__init__ and
from .DICOM_anonymizer import DICOMAnonymize
in turn imports DICOM_anonymizer.py which imports pydicom, which is not installed yet unless one manually installs the requirements in advance, which again should not be needed.

Please either move build.py out of the MedicalImageAnonymizer subdirectory or just put those two contained functions get_requires and read_description directly into setup.py which is the only place they are used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions