Skip to content

Commit 09a8343

Browse files
committed
Document release steps more visibly
1 parent 11e4435 commit 09a8343

1 file changed

Lines changed: 9 additions & 8 deletions

File tree

Makefile

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,27 +3,28 @@ SHELL = /usr/bin/env bash
33

44
_IMAGE_NAME = duolingo/pre-commit-hooks
55

6-
# Bumps this project's version number. Example:
7-
#
8-
# $ make release V=1.0.3
9-
#
10-
# After running this, you should push master and tags to GitHub and create a
11-
# corresponding GitHub release.
6+
# Bumps this project's version number. Example: make release V=1.0.3
127
.PHONY: release
138
release: test
149
# Validate
15-
[[ -n "${V}" ]]
16-
[[ -z "$$(git status --porcelain)" ]]
10+
[[ "$$(whoami)" = art ]] # Currently only @artnc can push to Docker Hub etc.
11+
[[ -n "${V}" ]] # New version number was provided
12+
[[ -z "$$(git status --porcelain)" ]] # Master is clean
1713

1814
# Update source files and commit
15+
echo 'Creating release commit...'
1916
git grep --cached -z -l '' | xargs -0 sed -E -i '' -e \
2017
"s@( rev: | entry: $(_IMAGE_NAME):)$$(git tag | tail -1)@\1${V}@g"
2118
git add -A
2219
git commit -m "Release ${V}" -n
2320

2421
# Tag
22+
echo 'Creating release tag...'
2523
git tag "${V}"
2624

25+
echo 'Done! Now you should `git push`, `git push --tags`, create a new'
26+
echo 'GitHub release for this tag, and run `make push` to update Docker Hub'
27+
2728
# Pushes to Docker Hub. Should be run when creating a GitHub release. We don't
2829
# use Docker Hub's autobuild feature anymore because it only supports amd64 :/
2930
# https://github.com/docker/roadmap/issues/109

0 commit comments

Comments
 (0)