refactor: migrate Xtend to Java - com.avaloq.tools.ddk.xtext.check.generator

Convert the module's two remaining Xtend generator fragments to hand-written Java, byte-faithful to the xtend-gen ground truth: CheckValidatorFragment2 and quickfix/CheckQuickfixProviderFragment2 (StringConcatenation(Client) templates preserved exactly, bracketed with CHECKSTYLE:CONSTANTS-OFF/ON).

Remove the now-unused per-module Xtend build wiring (xtend-gen entry in build.properties/.classpath, xtextBuilder/xtextNature in .project, the xtend-gen directory). Require-Bundle is unchanged: the templates legitimately use org.eclipse.xtend2.lib, provided transitively via org.eclipse.xtext(.xtext.generator).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: joaodinissf

com.avaloq.tools.ddk.xtext.check.generator/.classpath

@@ -1,7 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <classpath>
   <classpathentry kind="src" path="src"/>
-  <classpathentry kind="src" path="xtend-gen"/>
   <classpathentry kind="output" path="bin"/>
   <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-21"/>
   <classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins">

com.avaloq.tools.ddk.xtext.check.generator/.project

@@ -20,11 +20,6 @@
 			<arguments>
 			</arguments>
 		</buildCommand>
-		<buildCommand>
-			<name>org.eclipse.xtext.ui.shared.xtextBuilder</name>
-			<arguments>
-			</arguments>
-		</buildCommand>
 		<buildCommand>
 			<name>net.sf.eclipsecs.core.CheckstyleBuilder</name>
 			<arguments>
@@ -44,7 +39,6 @@
 	<natures>
 		<nature>org.eclipse.jdt.core.javanature</nature>
 		<nature>org.eclipse.pde.PluginNature</nature>
-		<nature>org.eclipse.xtext.ui.shared.xtextNature</nature>
 		<nature>net.sourceforge.pmd.eclipse.plugin.pmdNature</nature>
 		<nature>net.sf.eclipsecs.core.CheckstyleNature</nature>
 		<nature>edu.umd.cs.findbugs.plugin.eclipse.findbugsNature</nature>

com.avaloq.tools.ddk.xtext.check.generator/build.properties

@@ -1,5 +1,4 @@
-source.. = src/,\
-		   xtend-gen/
+source.. = src/
 output.. = bin/
 bin.includes = META-INF/,\
                .

…/generator/CheckValidatorFragment2.xtend …k/generator/CheckValidatorFragment2.javacom.avaloq.tools.ddk.xtext.check.generator/src/com/avaloq/tools/ddk/xtext/check/generator/CheckValidatorFragment2.xtend renamed to com.avaloq.tools.ddk.xtext.check.generator/src/com/avaloq/tools/ddk/xtext/check/generator/CheckValidatorFragment2.java com.avaloq.tools.ddk.xtext.check.generator/src/com/avaloq/tools/ddk/xtext/check/generator/CheckValidatorFragment2.xtend renamed to com.avaloq.tools.ddk.xtext.check.generator/src/com/avaloq/tools/ddk/xtext/check/generator/CheckValidatorFragment2.java

@@ -9,24 +9,28 @@
  *     Avaloq Group AG - initial API and implementation
  *******************************************************************************/
 
-package com.avaloq.tools.ddk.xtext.check.generator
+package com.avaloq.tools.ddk.xtext.check.generator;
 
-import org.eclipse.xtext.xtext.generator.AbstractXtextGeneratorFragment
-import static extension org.eclipse.xtext.xtext.generator.model.TypeReference.*
-import org.eclipse.xtext.xtext.generator.model.GuiceModuleAccess
-import com.avaloq.tools.ddk.check.runtime.validation.AbstractCheckValidator
-import com.avaloq.tools.ddk.check.runtime.validation.DefaultCheckValidator
+import org.eclipse.xtext.xtext.generator.AbstractXtextGeneratorFragment;
+import org.eclipse.xtext.xtext.generator.model.GuiceModuleAccess;
+import org.eclipse.xtext.xtext.generator.model.TypeReference;
 
-class CheckValidatorFragment2 extends AbstractXtextGeneratorFragment {
+import com.avaloq.tools.ddk.check.runtime.validation.AbstractCheckValidator;
+import com.avaloq.tools.ddk.check.runtime.validation.DefaultCheckValidator;
 
-  static val RUNTIME_PLUGIN = "com.avaloq.tools.ddk.check.runtime.core"
 
-  override generate() {
-    new GuiceModuleAccess.BindingFactory().addTypeToTypeEagerSingleton(AbstractCheckValidator.typeRef,
-      DefaultCheckValidator.typeRef).contributeTo(language.runtimeGenModule)
+@SuppressWarnings("nls")
+public class CheckValidatorFragment2 extends AbstractXtextGeneratorFragment {
 
-    if (projectConfig.runtime.manifest !== null) {
-      projectConfig.runtime.manifest.requiredBundles += RUNTIME_PLUGIN
+  private static final String RUNTIME_PLUGIN = "com.avaloq.tools.ddk.check.runtime.core";
+
+  @Override
+  public void generate() {
+    new GuiceModuleAccess.BindingFactory().addTypeToTypeEagerSingleton(TypeReference.typeRef(AbstractCheckValidator.class),
+        TypeReference.typeRef(DefaultCheckValidator.class)).contributeTo(getLanguage().getRuntimeGenModule());
+
+    if (getProjectConfig().getRuntime().getManifest() != null) {
+      getProjectConfig().getRuntime().getManifest().getRequiredBundles().add(RUNTIME_PLUGIN);
     }
   }
-}
+}

com.avaloq.tools.ddk.xtext.check.generator/src/com/avaloq/tools/ddk/xtext/check/generator/quickfix/CheckQuickfixProviderFragment2.java

@@ -0,0 +1,93 @@
+/*******************************************************************************
+ * Copyright (c) 2016 Avaloq Group AG and others.
+ * All rights reserved. This program and the accompanying materials
+ * are made available under the terms of the Eclipse Public License v1.0
+ * which accompanies this distribution, and is available at
+ * http://www.eclipse.org/legal/epl-v10.html
+ *
+ * Contributors:
+ *     Avaloq Group AG - initial API and implementation
+ *******************************************************************************/
+
+package com.avaloq.tools.ddk.xtext.check.generator.quickfix;
+
+import org.eclipse.xtend2.lib.StringConcatenationClient;
+import org.eclipse.xtext.Grammar;
+import org.eclipse.xtext.GrammarUtil;
+import org.eclipse.xtext.xtext.generator.AbstractXtextGeneratorFragment;
+import org.eclipse.xtext.xtext.generator.XtextGeneratorNaming;
+import org.eclipse.xtext.xtext.generator.model.FileAccessFactory;
+import org.eclipse.xtext.xtext.generator.model.TypeReference;
+
+import com.google.inject.Inject;
+
+
+@SuppressWarnings("nls")
+public class CheckQuickfixProviderFragment2 extends AbstractXtextGeneratorFragment {
+
+  private static final String UI_PLUGIN = "com.avaloq.tools.ddk.check.runtime.ui";
+
+  @Inject
+  private XtextGeneratorNaming xtextGeneratorNaming;
+
+  @Inject
+  private FileAccessFactory fileAccessFactory;
+
+  protected TypeReference getQuickfixProviderClass(final Grammar g) {
+    return new TypeReference(
+        xtextGeneratorNaming.getEclipsePluginBasePackage(g) + ".quickfix." + GrammarUtil.getSimpleName(g) + "QuickfixProvider");
+  }
+
+  @Override
+  public void generate() {
+    if (getProjectConfig().getEclipsePlugin().getManifest() != null) {
+      getProjectConfig().getEclipsePlugin().getManifest().getRequiredBundles().add(UI_PLUGIN);
+    }
+
+    if (getProjectConfig().getEclipsePlugin().getSrc() != null) {
+      generateQuickfixProvider();
+    }
+
+    if (getProjectConfig().getEclipsePlugin().getPluginXml() != null) {
+      addRegistrationToPluginXml();
+    }
+  }
+
+  protected void generateQuickfixProvider() {
+    final StringConcatenationClient content = new StringConcatenationClient() {
+      @Override
+      protected void appendTo(final TargetStringConcatenation builder) {
+        builder.append("""
+            public class %s extends DefaultCheckQuickfixProvider {
+
+            //  @Fix(MyJavaValidator.INVALID_NAME)
+            //  public void capitalizeName(final Issue issue, IssueResolutionAcceptor acceptor) {
+            //    acceptor.accept(issue, "Capitalize name", "Capitalize the name.", "upcase.png", new IModification() {
+            //      public void apply(IModificationContext context) throws BadLocationException {
+            //        IXtextDocument xtextDocument = context.getXtextDocument();
+            //        String firstLetter = xtextDocument.get(issue.getOffset(), 1);
+            //        xtextDocument.replace(issue.getOffset(), 1, firstLetter.toUpperCase());
+            //      }
+            //    });
+            //  }
+
+            }
+            """.formatted(getQuickfixProviderClass(getGrammar()).getSimpleName()));
+      }
+    };
+    fileAccessFactory.createJavaFile(getQuickfixProviderClass(getGrammar()), content).writeTo(getProjectConfig().getEclipsePlugin().getSrc());
+  }
+
+  protected void addRegistrationToPluginXml() {
+    final TypeReference executableExtensionFactory = xtextGeneratorNaming.getEclipsePluginExecutableExtensionFactory(getGrammar());
+    getProjectConfig().getEclipsePlugin().getPluginXml().getEntries().add("""
+        <!-- quickfix marker resolution generator -->
+        <extension
+              point="org.eclipse.ui.ide.markerResolution">
+           <markerResolutionGenerator
+                 class="%s:org.eclipse.xtext.ui.editor.quickfix.MarkerResolutionGenerator">
+           </markerResolutionGenerator>
+        </extension>
+        """.formatted(executableExtensionFactory));
+  }
+}