From 917b4b4e3057f43c49c2ea59a0d260e152c85c5f Mon Sep 17 00:00:00 2001 From: Larry Ewing Date: Sun, 27 Sep 2026 20:23:41 -0500 Subject: [PATCH] [wasm][R2R] Re-enable open virtual delegate runtime tests Runtime_79354 and Runtime_70259 were disabled on wasm ReadyToRun because invoking an open virtual delegate from R2R code hit portableEntryPoint->IsValid() in the interpreted delegate shuffle thunk. #134699 fixed that, so remove the ActiveIssue attributes and the TestLibrary references that were only needed for them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --- src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.cs | 2 -- src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.il | 6 ------ src/tests/JIT/Regression_o_3/Runtime_79354.cs | 2 -- 3 files changed, 10 deletions(-) diff --git a/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.cs b/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.cs index 8c7dcd9ebd9128..445faeefff72c6 100644 --- a/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.cs +++ b/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.cs @@ -8,13 +8,11 @@ using InlineIL; using System; using System.Runtime.CompilerServices; -using TestLibrary; using Xunit; class Runtime_70259 { [ActiveIssue("https://github.com/dotnet/runtime/issues/70279", TestRuntimes.Mono)] - [ActiveIssue("https://github.com/dotnet/runtime/issues/133169", typeof(PlatformDetection), nameof(PlatformDetection.IsWasm), nameof(PlatformDetection.IsReadyToRunCompiled))] private static int Main() { // This creates an open delegate that goes through shuffle thunk and diff --git a/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.il b/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.il index 2daaab5ddeef0e..b188d31e3e5218 100644 --- a/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.il +++ b/src/tests/JIT/Regression_2/Runtime_70259/Runtime_70259.il @@ -10,7 +10,6 @@ // Metadata version: v4.0.30319 .assembly extern System.Runtime { .publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A ) } .assembly extern xunit.core {} -.assembly extern TestLibrary { .ver 0:0:0:0 } .assembly extern Microsoft.DotNet.XUnitExtensions { .publickeytoken = (31 BF 38 56 AD 36 4E 35 ) } .assembly Runtime_70259 { @@ -72,11 +71,6 @@ string('https://github.com/dotnet/runtime/issues/70279') int32(0x2) // Mono } - .custom instance void [Microsoft.DotNet.XUnitExtensions]Xunit.ActiveIssueAttribute::.ctor(string, class [mscorlib]System.Type, string[]) = { - string('https://github.com/dotnet/runtime/issues/133169') - type([TestLibrary]TestLibrary.PlatformDetection) - string[2] ('IsWasm' 'IsReadyToRunCompiled') - } .entrypoint // Code size 31 (0x1f) .maxstack 8 diff --git a/src/tests/JIT/Regression_o_3/Runtime_79354.cs b/src/tests/JIT/Regression_o_3/Runtime_79354.cs index d3a4d7b75fc2e1..9f9ad8c34b58ed 100644 --- a/src/tests/JIT/Regression_o_3/Runtime_79354.cs +++ b/src/tests/JIT/Regression_o_3/Runtime_79354.cs @@ -7,7 +7,6 @@ namespace Runtime_79354; using System; using System.Reflection; -using TestLibrary; using Xunit; public interface IGetContents { @@ -29,7 +28,6 @@ public class Program { public delegate (string, int, string) MyDelegate(IGetContents arg); - [ActiveIssue("https://github.com/dotnet/runtime/issues/131886", typeof(PlatformDetection), nameof(PlatformDetection.IsWasm), nameof(PlatformDetection.IsReadyToRunCompiled))] [Fact] public static int TestEntryPoint() {