Skip to content

Version Updates#348

Merged
lmakarov merged 3 commits into
developfrom
feature/version-updates
Jun 1, 2026
Merged

Version Updates#348
lmakarov merged 3 commits into
developfrom
feature/version-updates

Conversation

@lmakarov

@lmakarov lmakarov commented Jun 1, 2026

Copy link
Copy Markdown
Member
  • PHP versions
    • 8.2.30 -> 8.2.31
    • 8.3.30 -> 8.3.31
    • 8.4.17 -> 8.4.21
    • 8.5.2 -> 8.5.6
  • Tools
    • gomplate 3.11.3 -> 5.1.0
    • Composer 1.10.27 -> 1.10.28
    • Composer 2.9.3 -> 2.10.0
    • Drush 8.4.12 -> 8.5.0
    • Platform.sh CLI 5.6.0 -> 5.9.0
    • Acquia CLI 2.55.0 -> 2.61.3
    • Terminus 4.1.1 -> 4.3.0
    • yq 4.50.1 -> 4.53.2
    • Node.js 24.13.0 -> 24.16.0
  • VS Code Server
    • VS Code Server 4.108.2 -> 4.122.0
    • VS Code GitLens 17.9.0 -> 2026.6.10649
    • VS Code Xdebug 1.40.0 -> 1.40.1

Summary by CodeRabbit

  • New Features

    • Added Microsoft SQL Server driver support in PHP 8.5
  • Chores

    • Updated PHP base images and runtime versions across all supported versions (8.2–8.5)
    • Updated bundled development tools and extensions including Composer, Drush, Node.js, code-server, and VS Code extensions

lmakarov added 3 commits June 1, 2026 16:05
- 8.2.31
- 8.3.31
- 8.4.21
- 8.5.6
gomplate 3.11.3 -> 5.1.0
Composer 1.10.27 -> 1.10.28
Composer 2.9.3 -> 2.10.0
Drush 8.4.12 -> 8.5.0
Platform.sh CLI 5.6.0 -> 5.9.0
Acquia CLI 2.55.0 -> 2.61.3
Terminus 4.1.1 -> 4.3.0
yq 4.50.1 -> 4.53.2
Node.js 24.13.0 -> 24.16.0

VS Code Server 4.108.2 -> 4.122.0
VS Code GitLens 17.9.0 -> 2026.6.10649
VS Code Xdebug 1.40.0 -> 1.40.1
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates all four versioned CLI service Dockerfiles (8.2, 8.3, 8.4, 8.5) with bumped base PHP images, upgraded bundled tooling versions, and development dependencies. PHP 8.5 additionally enables MSSQL database support by uncommenting previously disabled extensions and updating test fixtures to verify the modules load.

Changes

Version Updates Across PHP 8.2–8.5

Layer / File(s) Summary
Base images and tooling for PHP 8.2–8.4
8.2/Dockerfile, 8.3/Dockerfile, 8.4/Dockerfile
Base PHP FPM images bumped to 8.2.31, 8.3.31, and 8.4.21. Gomplate updated to 5.1.0, Composer/Drush/Platform.sh/Acquia/Terminus/YQ versions increased, Node.js via NVM set to 24.16.0. Code-server and extensions (GitLens, Xdebug) pinned to newer versions across all three versions.
Base image and tooling for PHP 8.5 with TERMINUS workaround removal
8.5/Dockerfile
PHP 8.5 image advanced from 8.5.2 to 8.5.6. Gomplate, Composer (1/2), Drush, CLI tools (Platform.sh, Acquia, Terminus), and yq versions updated. TERMINUS_ALLOW_UNSUPPORTED_NEWER_PHP environment override removed. Node.js bumped to 24.16.0 and code-server pins updated.
PHP 8.5 MSSQL extension enablement and test verification
8.5/Dockerfile, 8.5/tests/php-modules.sh
pdo_sqlsrv and sqlsrv PHP extensions uncommented and enabled in install list. Both extensions added to amd64 and arm64 module test lists to verify successful extension loading.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • docksal/service-cli#343: Both PRs modify MSSQL extension support in PHP 8.5 (main PR enables pdo_sqlsrv/sqlsrv; PR #343 removes them and comments out MSSQL extensions).
  • docksal/service-cli#344: Both PRs update the same code-server and Node.js version pins across multiple Dockerfile versions.
  • docksal/service-cli#338: Both PRs update the same Composer/CLI tool version pins (Composer, Acquia CLI, Terminus, yq) in the PHP cli stages.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Version Updates' is vague and generic, using a non-descriptive term that doesn't convey meaningful information about which versions or components were updated. Use a more specific title that identifies the primary change, such as 'Update PHP, tooling, and VS Code Server versions' or 'Bump PHP 8.2-8.5 and dependency versions'.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/version-updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
8.2/Dockerfile (1)

90-90: ⚡ Quick win

gomplate v5.1.0 bump: likely not impacted by v5.0.0 breaking changes used here

  • 8.2/Dockerfile sets GOMPLATE_VERSION=5.1.0 and downloads gomplate_linux-${TARGETARCH}.
  • 8.2/startup.sh invokes gomplate as gomplate --file "${tmpl}" --out "${file}" for local *.tmpl files; no .gomplate.yaml / templates: array-form config is used in this repo.
  • No references to AWS_META_ENDPOINT in the repo.

Still advisable to run a container startup (or template-render smoke test) to ensure the *.tmpl files render cleanly on gomplate v5.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@8.2/Dockerfile` at line 90, Dockerfile now sets GOMPLATE_VERSION=5.1.0 which
may expose compat issues; run a smoke test by building the image and starting
the container or by invoking the same gomplate call as in startup.sh (gomplate
--file "${tmpl}" --out "${file}") against all local *.tmpl files to ensure they
render cleanly; if rendering fails, either adjust the templates to be compatible
with gomplate v5.x or pin GOMPLATE_VERSION back to the previously known-good
version in the Dockerfile, and re-run the smoke test until all templates
referenced by startup.sh succeed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@8.2/Dockerfile`:
- Line 90: Dockerfile now sets GOMPLATE_VERSION=5.1.0 which may expose compat
issues; run a smoke test by building the image and starting the container or by
invoking the same gomplate call as in startup.sh (gomplate --file "${tmpl}"
--out "${file}") against all local *.tmpl files to ensure they render cleanly;
if rendering fails, either adjust the templates to be compatible with gomplate
v5.x or pin GOMPLATE_VERSION back to the previously known-good version in the
Dockerfile, and re-run the smoke test until all templates referenced by
startup.sh succeed.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c0c8016-1a69-46cc-bcb2-29bdfd9f8237

📥 Commits

Reviewing files that changed from the base of the PR and between 9785e99 and 895669d.

📒 Files selected for processing (5)
  • 8.2/Dockerfile
  • 8.3/Dockerfile
  • 8.4/Dockerfile
  • 8.5/Dockerfile
  • 8.5/tests/php-modules.sh

@lmakarov lmakarov merged commit 55714a4 into develop Jun 1, 2026
21 checks passed
@lmakarov lmakarov deleted the feature/version-updates branch June 1, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant