Merge pull request #14 from funkypenguin/default-to-strategy-recreate

Default to a strategy of recreate

Author: funkypenguin

.circleci/config.yml

@@ -2,7 +2,7 @@ apiVersion: v1
 appVersion: "6.3.0"
 description: A fullstack but simple mailserver (smtp, imap, antispam, antivirus, ssl...) using Docker.
 name: docker-mailserver
-version: 0.2.4-pre1
+version: 0.2.4-pre2
 sources:
 - https://github.com/funkypenguin/helm-docker-mailserver
 maintainers:

.circleci/prep-kubeval.sh

@@ -109,13 +109,13 @@ pod:
 
     ## Update strategy - only really applicable for deployments with RWO PVs attached
     ## If replicas = 1, an update can get "stuck", as the previous pod remains attached to the 
-    ## PV, and the "incoming" pod can never start. Changing the strategy to "Recreate" will 
+    ## PV, and the "incoming" pod can never start. Setting the strategy to "Recreate" (our default) will 
     ## terminate the single previous pod, so that the new, incoming pod can attach to the PV    
-    strategy: {}
+    strategy:
       # rollingUpdate:
       #   maxSurge: 1
       #   maxUnavailable: 1
-      # type: "RollingUpdate"
+      type: "Recreate"
 
     ## The following variables affect the behaviour of docker-mailserver
     ## See https://github.com/tomav/docker-mailserver#environment-variables for details
@@ -330,13 +330,13 @@ rainloop:
 
     ## Update strategy - only really applicable for deployments with RWO PVs attached
     ## If replicas = 1, an update can get "stuck", as the previous pod remains attached to the 
-    ## PV, and the "incoming" pod can never start. Changing the strategy to "Recreate" will 
-    ## terminate the single previous pod, so that the new, incoming pod can attach to the PV    
-    strategy: {}
+    ## PV, and the "incoming" pod can never start. Setting the strategy to "Recreate" (our default) will 
+    ## terminate the single previous pod, so that the new, incoming pod can attach to the PV.    
+    strategy:
       # rollingUpdate:
       #   maxSurge: 1
       #   maxUnavailable: 1
-      # type: "RollingUpdate"
+      type: "Recreate"
 
   persistence:
     size: "1Gi"