Skip to content

Commit 99ebcc0

Browse files
committed
Fix comments in values.yaml for initContainer resources
These comments appear to be copy/paste from the resource descriptions for the main mail server container resource limits, and do not make sense in this context. It also finishes a sentence which was either cut off or never ...finished. :)
1 parent 4b2cc5a commit 99ebcc0

1 file changed

Lines changed: 3 additions & 12 deletions

File tree

charts/docker-mailserver/values.yaml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,27 +8,18 @@ image:
88

99
initContainer:
1010
image:
11-
# image.name is the name of the container image to use. Refer to https://hub.docker.com/r/tvial/docker-mailserver
1211
name: "busybox"
13-
# image.tag is the tag of the container image to use. Refer to https://hub.docker.com/r/tvial/docker-mailserver
1412
tag: "1.28"
1513
pullPolicy: "IfNotPresent"
1614

17-
# These resources refer specifically to the _init container_, which needs only _puny_ resources, since all it does
18-
15+
# These resources refer specifically to the _init container_, which needs only _puny_ resources,
16+
# since all it does is copy the config into place
1917
resources:
2018
requests:
21-
## How much CPU this container is expected to need
2219
cpu: "10m"
23-
## How much memory this container is expected to need.
24-
## Reduce these at requests your peril - too few resources can cause daemons (i.e., clamd) to fail, or timeouts to occur.
25-
## A test installation with clamd running was killed when it consumed 1437Mi (which is why this value was increased to 1536)
2620
memory: "32Mi"
2721
limits:
28-
## The max CPU this container should be allowed to use
2922
cpu: "50m"
30-
## The max memory this container should be allowed to use. Note: If a container exceeds its memory limit,
31-
## it may terminated.
3223
memory: "64Mi"
3324

3425
serviceAccount:
@@ -400,4 +391,4 @@ haproxy:
400391

401392
# 10 is the default, but explicitly setting this value avoids a CI error when running the generated manifest through kubeval
402393
# Will be fixed with an upstream PR
403-
revisionHistoryLimit: 10
394+
revisionHistoryLimit: 10

0 commit comments

Comments
 (0)