Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit bead27a

Browse files
committed
Merge pull request #106 from dmcgowan/fix-spdy-unit-test
Remove bad local stream reference storage
2 parents a21c8f1 + 2202b62 commit bead27a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

spdy/session.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,10 @@ func (s *Transport) createSubStream(parentID uint64) (*stream, error) {
159159
session: s,
160160
}
161161

162-
// TODO: Do not store reference
163-
s.streamC.L.Lock()
164-
s.streams[referenceID] = newStream
165-
s.streamC.L.Unlock()
162+
// TODO: hold reference to the newly created stream
163+
// for possible cleanup. This stream should not be put
164+
// in the streams maps which holds remotely created
165+
// streams and will can have reference id conflicts.
166166

167167
return newStream, nil
168168

0 commit comments

Comments
 (0)