From 5102b0c1b5a1f74ee832ea2203166773757abfd8 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sat, 7 Nov 2026 13:37:04 -0600 Subject: [PATCH 1/2] fix(tunnelserver): handle stream eof during lifecycle terminal close --- pkg/agent/tunnelserver/lifecycle_terminal_client.go | 13 +++++++++++++ pkg/agent/tunnelserver/lifecycle_terminal_test.go | 13 +++++++++++++ 2 files changed, 26 insertions(+) diff --git a/pkg/agent/tunnelserver/lifecycle_terminal_client.go b/pkg/agent/tunnelserver/lifecycle_terminal_client.go index a66610082..0a2366248 100644 --- a/pkg/agent/tunnelserver/lifecycle_terminal_client.go +++ b/pkg/agent/tunnelserver/lifecycle_terminal_client.go @@ -257,6 +257,9 @@ func (s *terminalClient) Close(ctx context.Context) error { }, }, ) + if errors.Is(err, io.EOF) { + err = nil + } if err == nil { select { case <-s.recvDone: @@ -619,6 +622,11 @@ func (s *terminalClient) sendItem(ctx context.Context, item terminalSend) error return s.failure() } select { + case err := <-item.done: + return err + default: + } + select { case err := <-item.done: return err case <-ctx.Done(): @@ -642,6 +650,11 @@ func (s *terminalClient) sendOutput( return s.failure() } select { + case err := <-item.done: + return err + default: + } + select { case err := <-item.done: return err case <-ctx.Done(): diff --git a/pkg/agent/tunnelserver/lifecycle_terminal_test.go b/pkg/agent/tunnelserver/lifecycle_terminal_test.go index a929ba833..6a3b45ea9 100644 --- a/pkg/agent/tunnelserver/lifecycle_terminal_test.go +++ b/pkg/agent/tunnelserver/lifecycle_terminal_test.go @@ -428,6 +428,19 @@ func (s *terminalSuite) TestConcurrentOwnerSendsSerialize() { s.NoError(session.Close(context.Background())) } +func (s *terminalSuite) TestCloseAfterServerStreamClosed() { + owner := testTerminalOwner{ + serve: func(_ context.Context, st tunnel.Tunnel_LifecycleTerminalServer) error { + return ready(st) + }, + } + client := s.client(WithLifecycleTerminalOwner(owner, s.req)) + session, err := OpenLifecycleTerminal(context.Background(), client, s.req) + s.Require().NoError(err) + time.Sleep(50 * time.Millisecond) + s.NoError(session.Close(context.Background())) +} + func (s *terminalSuite) TestGoroutinesExitAfterClose() { owner := testTerminalOwner{ serve: func(_ context.Context, st tunnel.Tunnel_LifecycleTerminalServer) error { From 4b177b3c812ee1aab250f4280cacda33b5374ff0 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sat, 7 Nov 2026 14:19:25 -0600 Subject: [PATCH 2/2] fix(tunnelserver): preserve receive error and synchronize terminal close test --- .../tunnelserver/lifecycle_terminal_client.go | 56 +++++++++++++------ .../tunnelserver/lifecycle_terminal_test.go | 25 ++++++++- 2 files changed, 62 insertions(+), 19 deletions(-) diff --git a/pkg/agent/tunnelserver/lifecycle_terminal_client.go b/pkg/agent/tunnelserver/lifecycle_terminal_client.go index 0a2366248..681e50cc1 100644 --- a/pkg/agent/tunnelserver/lifecycle_terminal_client.go +++ b/pkg/agent/tunnelserver/lifecycle_terminal_client.go @@ -42,6 +42,7 @@ type terminalClient struct { active *terminalAttachment closed bool err error + recvErr error term string phase terminalClientPhase } @@ -263,7 +264,12 @@ func (s *terminalClient) Close(ctx context.Context) error { if err == nil { select { case <-s.recvDone: - if !errors.Is(s.failure(), io.EOF) { + s.mu.Lock() + rerr := s.recvErr + s.mu.Unlock() + if rerr != nil && !errors.Is(rerr, io.EOF) { + err = rerr + } else if !errors.Is(s.failure(), io.EOF) { err = s.failure() } case <-ctx.Done(): @@ -455,10 +461,16 @@ func (s *terminalClient) receiveLoop() { for { frame, err := s.stream.Recv() if err != nil { + s.mu.Lock() + s.recvErr = err + s.mu.Unlock() s.fail(err) return } if err = s.handleResponse(frame); err != nil { + s.mu.Lock() + s.recvErr = err + s.mu.Unlock() s.fail(err) return } @@ -597,7 +609,7 @@ func (s *terminalClient) handleCancel(f *tunnel.LifecycleTerminalResponse_Cancel func (s *terminalClient) fail(err error) { s.mu.Lock() - if s.err == nil { + if s.err == nil || (errors.Is(s.err, io.EOF) && !errors.Is(err, io.EOF)) { s.err = err } a := s.active @@ -622,18 +634,23 @@ func (s *terminalClient) sendItem(ctx context.Context, item terminalSend) error return s.failure() } select { - case err := <-item.done: - return err - default: - } - select { case err := <-item.done: return err case <-ctx.Done(): - s.fail(ctx.Err()) - return ctx.Err() + select { + case err := <-item.done: + return err + default: + s.fail(ctx.Err()) + return ctx.Err() + } case <-s.ctx.Done(): - return s.failure() + select { + case err := <-item.done: + return err + default: + return s.failure() + } } } @@ -650,17 +667,22 @@ func (s *terminalClient) sendOutput( return s.failure() } select { - case err := <-item.done: - return err - default: - } - select { case err := <-item.done: return err case <-ctx.Done(): - return ctx.Err() + select { + case err := <-item.done: + return err + default: + return ctx.Err() + } case <-s.ctx.Done(): - return s.failure() + select { + case err := <-item.done: + return err + default: + return s.failure() + } } } diff --git a/pkg/agent/tunnelserver/lifecycle_terminal_test.go b/pkg/agent/tunnelserver/lifecycle_terminal_test.go index 6a3b45ea9..98daf4ec0 100644 --- a/pkg/agent/tunnelserver/lifecycle_terminal_test.go +++ b/pkg/agent/tunnelserver/lifecycle_terminal_test.go @@ -429,15 +429,36 @@ func (s *terminalSuite) TestConcurrentOwnerSendsSerialize() { } func (s *terminalSuite) TestCloseAfterServerStreamClosed() { + release := make(chan struct{}) owner := testTerminalOwner{ serve: func(_ context.Context, st tunnel.Tunnel_LifecycleTerminalServer) error { - return ready(st) + if err := ready(st); err != nil { + return err + } + <-release + return nil }, } client := s.client(WithLifecycleTerminalOwner(owner, s.req)) session, err := OpenLifecycleTerminal(context.Background(), client, s.req) s.Require().NoError(err) - time.Sleep(50 * time.Millisecond) + close(release) + s.Eventually( + func() bool { + tc, ok := session.(*terminalClient) + if !ok { + return false + } + select { + case <-tc.recvDone: + return true + default: + return false + } + }, + 5*time.Second, + 10*time.Millisecond, + ) s.NoError(session.Close(context.Background())) }