From 29e427c10be0942a577bddb74e9f2ecedf98bd24 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Sun, 1 Nov 2026 01:15:21 -0600 Subject: [PATCH 01/15] feat(workspace): separate display label and SSH host alias from workspace ID --- .agents/skills/devsy/references/cli.md | 1 + cmd/workspace/describe.go | 22 +- cmd/workspace/edit.go | 210 ++++++ cmd/workspace/edit_test.go | 223 ++++++ cmd/workspace/list.go | 41 +- cmd/workspace/list_presentation_test.go | 77 +++ cmd/workspace/up/configure.go | 14 + cmd/workspace/up/detach.go | 13 + cmd/workspace/up/presentation_test.go | 60 ++ cmd/workspace/up/up.go | 3 + cmd/workspace/up/up_client.go | 96 ++- cmd/workspace/up/up_flags.go | 13 + cmd/workspace/workspace.go | 1 + desktop/e2e/integration.e2e.ts | 1 + desktop/e2e/workspace-id.e2e.ts | 2 +- .../__tests__/workspace-presentation.test.ts | 485 ++++++++++++++ desktop/src/main/index.ts | 1 + desktop/src/main/ipc.ts | 83 +++ desktop/src/main/state.ts | 4 + desktop/src/main/tray.ts | 3 +- .../lib/components/layout/Breadcrumbs.svelte | 11 +- .../components/layout/CommandPalette.svelte | 10 +- .../components/workspace/WorkspaceCard.svelte | 5 +- .../workspace/WorkspaceLaunchProgress.svelte | 7 +- .../workspace/WorkspaceWizard.svelte | 119 +++- .../workspace/WorkspaceWizard.test.ts | 115 ++++ .../src/renderer/src/lib/ipc/commands.test.ts | 67 ++ desktop/src/renderer/src/lib/ipc/commands.ts | 34 + desktop/src/renderer/src/lib/ipc/mock.test.ts | 49 ++ desktop/src/renderer/src/lib/ipc/mock.ts | 111 +++ .../src/lib/stores/command-palette.ts | 1 + .../src/lib/stores/workspaces.test.ts | 51 ++ .../src/renderer/src/lib/stores/workspaces.ts | 21 + desktop/src/renderer/src/lib/types/index.ts | 11 + .../src/lib/utils/workspaceLabel.test.ts | 106 +++ .../renderer/src/lib/utils/workspaceLabel.ts | 68 ++ .../renderer/src/pages/DashboardPage.svelte | 3 +- .../renderer/src/pages/TerminalsPage.svelte | 5 +- .../src/pages/WorkspaceDetailPage.svelte | 249 ++++++- .../src/pages/WorkspaceDetailPage.test.ts | 277 ++++++++ .../pages/WorkspaceDetailPageHarness.svelte | 10 + .../renderer/src/pages/WorkspacesPage.svelte | 23 +- desktop/src/shared/workspace-label.ts | 22 + desktop/src/shared/workspace-presentation.ts | 294 ++++++++ e2e/framework/command.go | 15 + e2e/tests/rename/rename.go | 51 ++ go.mod | 2 +- pkg/flags/names/names.go | 4 + pkg/flags/names/names_test.go | 4 + pkg/ide/jetbrains/generic.go | 22 +- pkg/ide/jetbrains/generic_test.go | 12 + pkg/ide/opener/opener.go | 23 +- pkg/ide/opener/opener_test.go | 35 + pkg/ide/vscode/open.go | 10 +- pkg/ide/vscode/open_test.go | 44 +- pkg/ide/zed/url.go | 11 + pkg/ide/zed/url_test.go | 32 + pkg/ide/zed/zed.go | 10 +- pkg/ide/zed/zed_linux.go | 10 +- pkg/provider/dir.go | 54 +- pkg/provider/workspace.go | 26 + pkg/ssh/config.go | 67 +- pkg/ssh/config_alias.go | 128 ++++ pkg/ssh/config_alias_test.go | 365 ++++++++++ pkg/ssh/config_conflicts.go | 228 +++++++ pkg/ssh/config_lock.go | 129 ++++ pkg/workspace/presentation.go | 503 ++++++++++++++ pkg/workspace/presentation_test.go | 633 ++++++++++++++++++ 68 files changed, 5315 insertions(+), 125 deletions(-) create mode 100644 cmd/workspace/edit.go create mode 100644 cmd/workspace/edit_test.go create mode 100644 cmd/workspace/list_presentation_test.go create mode 100644 cmd/workspace/up/presentation_test.go create mode 100644 desktop/src/main/__tests__/workspace-presentation.test.ts create mode 100644 desktop/src/renderer/src/lib/utils/workspaceLabel.test.ts create mode 100644 desktop/src/renderer/src/lib/utils/workspaceLabel.ts create mode 100644 desktop/src/renderer/src/pages/WorkspaceDetailPage.test.ts create mode 100644 desktop/src/renderer/src/pages/WorkspaceDetailPageHarness.svelte create mode 100644 desktop/src/shared/workspace-label.ts create mode 100644 desktop/src/shared/workspace-presentation.ts create mode 100644 pkg/ide/zed/url.go create mode 100644 pkg/ide/zed/url_test.go create mode 100644 pkg/ssh/config_alias.go create mode 100644 pkg/ssh/config_alias_test.go create mode 100644 pkg/ssh/config_conflicts.go create mode 100644 pkg/ssh/config_lock.go create mode 100644 pkg/workspace/presentation.go create mode 100644 pkg/workspace/presentation_test.go diff --git a/.agents/skills/devsy/references/cli.md b/.agents/skills/devsy/references/cli.md index f3b46e6daf..8720ce6bac 100644 --- a/.agents/skills/devsy/references/cli.md +++ b/.agents/skills/devsy/references/cli.md @@ -66,6 +66,7 @@ flags before using them. | --- | --- | | `devsy workspace build ` | Build/prebuild the workspace environment; publishing behavior depends on flags/configuration. Inspect help and requested destination first. | | `devsy workspace rename ` | Change workspace identity; refresh discovery afterward. | +| `devsy workspace edit [--display-name