From 3d29c29ec45b21481bb6457471f66eb7d18d3933 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Tue, 27 Oct 2026 00:26:07 -0600 Subject: [PATCH 1/3] test(platform): cover instance readiness and template sync gates --- pkg/platform/instance_test.go | 89 +++++++++++++++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 pkg/platform/instance_test.go diff --git a/pkg/platform/instance_test.go b/pkg/platform/instance_test.go new file mode 100644 index 000000000..cb8612992 --- /dev/null +++ b/pkg/platform/instance_test.go @@ -0,0 +1,89 @@ +package platform + +import ( + "testing" + + agentstoragev1 "github.com/devsy-org/agentapi/pkg/apis/devsy/storage/v1" + managementv1 "github.com/devsy-org/api/pkg/apis/management/v1" + storagev1 "github.com/devsy-org/api/pkg/apis/storage/v1" + "github.com/stretchr/testify/suite" + corev1 "k8s.io/api/core/v1" +) + +type instanceReadinessSuite struct { + suite.Suite +} + +func TestInstanceReadinessSuite(t *testing.T) { + suite.Run(t, new(instanceReadinessSuite)) +} + +func newInstanceWithPhase(phase storagev1.InstancePhase) *managementv1.DevsyWorkspaceInstance { + instance := &managementv1.DevsyWorkspaceInstance{} + instance.Status.Phase = phase + return instance +} + +func templateResolvedCondition(status corev1.ConditionStatus) agentstoragev1.Condition { + return agentstoragev1.Condition{ + Type: storagev1.InstanceTemplateResolved, + Status: status, + } +} + +func (s *instanceReadinessSuite) TestIsReadyTreatsSleepingAsReady() { + s.True(isReady(newInstanceWithPhase(storagev1.InstanceSleeping))) + s.True(isReady(newInstanceWithPhase(storagev1.InstanceReady))) +} + +func (s *instanceReadinessSuite) TestIsReadyRejectsOtherPhases() { + s.False(isReady(newInstanceWithPhase(storagev1.InstancePending))) + s.False(isReady(newInstanceWithPhase(""))) +} + +func (s *instanceReadinessSuite) TestIsTemplateSyncedRequiresResolvedTrueCondition() { + instance := newInstanceWithPhase(storagev1.InstanceReady) + s.False(isTemplateSynced(instance), "no conditions must not count as synced") + + instance.Status.Conditions = agentstoragev1.Conditions{ + templateResolvedCondition(corev1.ConditionFalse), + } + s.False(isTemplateSynced(instance)) + + instance.Status.Conditions = agentstoragev1.Conditions{ + templateResolvedCondition(corev1.ConditionTrue), + } + s.True(isTemplateSynced(instance)) +} + +func (s *instanceReadinessSuite) TestIsTemplateSyncedIgnoresUnrelatedConditions() { + instance := newInstanceWithPhase(storagev1.InstanceReady) + instance.Status.Conditions = agentstoragev1.Conditions{ + {Type: "SomethingElse", Status: corev1.ConditionTrue}, + } + s.False(isTemplateSynced(instance)) +} + +func (s *instanceReadinessSuite) TestIsTemplateSyncedSyncOnceOverridesResolvedCondition() { + instance := newInstanceWithPhase(storagev1.InstanceReady) + instance.Spec.TemplateRef = &storagev1.TemplateRef{SyncOnce: true} + instance.Status.Conditions = agentstoragev1.Conditions{ + templateResolvedCondition(corev1.ConditionTrue), + } + s.False( + isTemplateSynced(instance), + "SyncOnce must hold the instance unsynced until the controller clears it", + ) +} + +func (s *instanceReadinessSuite) TestInstanceReadyRequiresPhaseAndTemplateSync() { + s.False(instanceReady(newInstanceWithPhase(storagev1.InstancePending))) + + instance := newInstanceWithPhase(storagev1.InstanceReady) + s.False(instanceReady(instance), "ready phase alone is not enough without template sync") + + instance.Status.Conditions = agentstoragev1.Conditions{ + templateResolvedCondition(corev1.ConditionTrue), + } + s.True(instanceReady(instance)) +} From 5ce911fdb42de9891a7a98457279de583129df7f Mon Sep 17 00:00:00 2001 From: Samuel K Date: Tue, 27 Oct 2026 01:32:36 -0600 Subject: [PATCH 2/3] test(platform): isolate pending phase in instance readiness test --- pkg/platform/instance_test.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkg/platform/instance_test.go b/pkg/platform/instance_test.go index cb8612992..9d6a50100 100644 --- a/pkg/platform/instance_test.go +++ b/pkg/platform/instance_test.go @@ -77,7 +77,14 @@ func (s *instanceReadinessSuite) TestIsTemplateSyncedSyncOnceOverridesResolvedCo } func (s *instanceReadinessSuite) TestInstanceReadyRequiresPhaseAndTemplateSync() { - s.False(instanceReady(newInstanceWithPhase(storagev1.InstancePending))) + pending := newInstanceWithPhase(storagev1.InstancePending) + pending.Status.Conditions = agentstoragev1.Conditions{ + templateResolvedCondition(corev1.ConditionTrue), + } + s.False( + instanceReady(pending), + "pending phase must block readiness even when template is synced", + ) instance := newInstanceWithPhase(storagev1.InstanceReady) s.False(instanceReady(instance), "ready phase alone is not enough without template sync") From 2af0d42dddb17ea3135c8dc7161d0dd64a6860d0 Mon Sep 17 00:00:00 2001 From: Samuel K Date: Tue, 27 Oct 2026 02:39:23 -0600 Subject: [PATCH 3/3] test(platform): cover SyncOnce readiness gate at instanceReady --- pkg/platform/instance_test.go | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/pkg/platform/instance_test.go b/pkg/platform/instance_test.go index 9d6a50100..8b9664aa2 100644 --- a/pkg/platform/instance_test.go +++ b/pkg/platform/instance_test.go @@ -94,3 +94,15 @@ func (s *instanceReadinessSuite) TestInstanceReadyRequiresPhaseAndTemplateSync() } s.True(instanceReady(instance)) } + +func (s *instanceReadinessSuite) TestInstanceReadyRejectsSyncOnceWhenTemplateResolved() { + instance := newInstanceWithPhase(storagev1.InstanceReady) + instance.Spec.TemplateRef = &storagev1.TemplateRef{SyncOnce: true} + instance.Status.Conditions = agentstoragev1.Conditions{ + templateResolvedCondition(corev1.ConditionTrue), + } + s.False( + instanceReady(instance), + "SyncOnce must block readiness until the controller clears it", + ) +}