From a9b5b5d3b5c40ba0b3e3d0297f6066278fa58f89 Mon Sep 17 00:00:00 2001 From: "devsy-app[bot]" <277138668+devsy-app[bot]@users.noreply.github.com> Date: Sat, 15 Aug 2026 13:24:29 +0000 Subject: [PATCH] fix(ui): add dark-mode variants to ssh keys icons MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Problem On `desktop/src/renderer/src/pages/SshKeysPage.svelte`, three status-icon color classes lacked dark-mode variants, so the passphrase/no-passphrase `ShieldCheck`/`ShieldAlert` icons render with low contrast in dark mode. This was also internally inconsistent: the same file already used `text-green-600 dark:text-green-400` for the `ShieldCheck` icon in the key list (line 178), but the legend below used bare `text-green-600`, and both `ShieldAlert` icons used bare `text-amber-500` with no dark variant — while the rest of the app uses `text-amber-600 dark:text-amber-400` for amber status icons (e.g. `WorkspaceDetailPage.svelte`). ## Change Added the `dark:` variant to the three affected icon classes on `SshKeysPage.svelte` to match the established pattern: - Line 180: `ShieldAlert` `text-amber-500` → `text-amber-600 dark:text-amber-400` - Line 207: legend `ShieldCheck` `text-green-600` → `text-green-600 dark:text-green-400` (matches line 178 in the same file) - Line 208: legend `ShieldAlert` `text-amber-500` → `text-amber-600 dark:text-amber-400` Pure CSS class additions; no behavioral, structural, or logic change. ## Why it's safe / reviewable in <15 min Touches a single file, three class strings. No routing, store, IPC, or data-flow changes. No new dependencies. A reviewer can verify the diff by eye and confirm the classes match the existing green/amber dark-mode pattern already used elsewhere in the file and app. ## Verification - `cd desktop && npm run check` (svelte-check): 0 errors, 0 warnings - `cd desktop && npx vitest run`: 48 tests passed (6 files). (32 unrelated jsdom/undici environment errors are pre-existing on `main` — a `webidl.util.markAsUncloneable is not a function` Node 20 vs undici incompatibility, not caused by this CSS change.) - `task cli:format`: clean - `task cli:lint:ci`: 0 issues - `task cli:test`: only the known pre-existing `pkg/git` `TestRepoClone*` failures (stale assertion on `origin/main`, unrelated to this change); all other packages pass This PR was created by an AI agent as part of an automated daily UI polish job. --- desktop/src/renderer/src/pages/SshKeysPage.svelte | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/desktop/src/renderer/src/pages/SshKeysPage.svelte b/desktop/src/renderer/src/pages/SshKeysPage.svelte index c54332e050..6f6719f01e 100644 --- a/desktop/src/renderer/src/pages/SshKeysPage.svelte +++ b/desktop/src/renderer/src/pages/SshKeysPage.svelte @@ -177,7 +177,7 @@ async function copyPublicKey(key: SshKeyInfo) { {#if key.hasPassphrase} {:else} - + {/if} {#if key.comment} @@ -204,8 +204,8 @@ async function copyPublicKey(key: SshKeyInfo) {

- Keys with have a passphrase. - Keys with do not. + Keys with have a passphrase. + Keys with do not.

{/if}