fix: run helm registry login

Author: FabianKramm

pkg/devspace/config/loader/variable/runtime/runtime_variable.go

@@ -22,14 +22,17 @@ var Locations = []string{
 	"/hooks/*/container/imageSelector",
 	"/dev/*/imageSelector",
 	"/dev/*/replaceImage",
+	"/dev/*/devImage",
 	"/dev/*/containers/*/replaceImage",
+	"/dev/*/containers/*/devImage",
 	"/dev/ports/*/imageSelector",
 	"/dev/sync/*/imageSelector",
 	"/dev/logs/*/selectors/*/imageSelector",
 	"/dev/replacePods/*/imageSelector",
 	"/dev/replacePods/*/replaceImage",
 	"/dev/terminal/imageSelector",
 	"/pipelines/*",
+	"/pipelines/*/flags/**",
 	"/pipelines/*/run",
 	"/commands/*",
 	"/commands/*/command",

pkg/devspace/helm/generic/generic.go

@@ -74,7 +74,7 @@ func (c *client) Exec(ctx devspacecontext.Context, args []string) ([]byte, error
 	}
 
 	// disable log for list, because it prints same command multiple times if we've multiple deployments.
-	if args[0] != "list" {
+	if args[0] != "list" && args[0] != "registry" && (len(args) == 1 || args[1] != "login") {
 		c.log.Debugf("Execute '%s %s'", c.helmPath, strings.Join(args, " "))
 	}
 

pkg/devspace/helm/v3/client.go

@@ -3,10 +3,12 @@ package v3
 import (
 	devspacecontext "github.com/loft-sh/devspace/pkg/devspace/context"
 	dependencyutil "github.com/loft-sh/devspace/pkg/devspace/dependency/util"
+	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 	"os"
 	"path/filepath"
 	"strconv"
+	"strings"
 
 	"github.com/ghodss/yaml"
 	"github.com/loft-sh/devspace/pkg/devspace/config/versions/latest"
@@ -71,11 +73,22 @@ func (c *client) InstallChart(ctx devspacecontext.Context, releaseName string, r
 		if helmConfig.Chart.Version != "" {
 			args = append(args, "--version", helmConfig.Chart.Version)
 		}
-		if helmConfig.Chart.Username != "" {
-			args = append(args, "--username", helmConfig.Chart.Username)
-		}
-		if helmConfig.Chart.Password != "" {
-			args = append(args, "--password", helmConfig.Chart.Password)
+
+		// log into OCI registry if specified
+		if strings.HasPrefix(chartName, "oci://") {
+			if helmConfig.Chart.Username != "" && helmConfig.Chart.Password != "" {
+				_, err := c.genericHelm.Exec(ctx, []string{"registry", "login", "--username", helmConfig.Chart.Username, "--password", helmConfig.Chart.Password})
+				if err != nil {
+					return nil, errors.Wrap(err, "login oci registry")
+				}
+			}
+		} else {
+			if helmConfig.Chart.Username != "" {
+				args = append(args, "--username", helmConfig.Chart.Username)
+			}
+			if helmConfig.Chart.Password != "" {
+				args = append(args, "--password", helmConfig.Chart.Password)
+			}
 		}
 	}