fix: tag replaced incorrectly when using dev.*.imageSelector with predefined tag

lizardruss · lizardruss · commit 9ef3551ce1c5 · 2023-02-09T06:38:34.000-05:00
Signed-off-by: Russell Centanni &lt;russell.centanni@gmail.com&gt;
diff --git a/pkg/devspace/config/loader/variable/legacy/replace.go b/pkg/devspace/config/loader/variable/legacy/replace.go
@@ -175,7 +175,7 @@ func resolveImage(value string, config config2.Config, dependencies []types.Depe
 
 		// try to find the tag for the image
 		tag := originalTag
-		if imageCache.Tag != "" {
+		if tag == "" && imageCache.Tag != "" {
 			tag = imageCache.Tag
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ func resolveImage(value string, config config2.Config, dependencies []types.Depe`
`175`	`175`
`176`	`176`	`// try to find the tag for the image`
`177`	`177`	`tag := originalTag`
`178`		`- if imageCache.Tag != "" {`
	`178`	`+ if tag == "" && imageCache.Tag != "" {`
`179`	`179`	`tag = imageCache.Tag`
`180`	`180`	`}`
`181`	`181`