fix: download once

Author: FabianKramm

pkg/devspace/dependency/util/util.go

@@ -36,6 +36,34 @@ func init() {
 // downloadMutex makes sure we only download a single dependency at a time
 var downloadMutex = sync.Mutex{}
 
+func GetDependencyPath(workingDirectory string, source *latest.SourceConfig) (configPath string, err error) {
+	ID, err := GetDependencyID(source)
+	if err != nil {
+		return "", err
+	}
+
+	// Resolve source
+	var localPath string
+	if source.Git != "" {
+		localPath = filepath.Join(DependencyFolderPath, ID)
+	} else if source.Path != "" {
+		if isURL(source.Path) {
+			localPath = filepath.Join(DependencyFolderPath, ID)
+		} else {
+			if filepath.IsAbs(source.Path) {
+				localPath = source.Path
+			} else {
+				localPath, err = filepath.Abs(filepath.Join(workingDirectory, filepath.FromSlash(source.Path)))
+				if err != nil {
+					return "", errors.Wrap(err, "filepath absolute")
+				}
+			}
+		}
+	}
+
+	return getDependencyConfigPath(localPath, source)
+}
+
 func DownloadDependency(ctx context.Context, workingDirectory string, source *latest.SourceConfig, log log.Logger) (configPath string, err error) {
 	downloadMutex.Lock()
 	defer downloadMutex.Unlock()

pkg/devspace/deploy/deployer/helm/deploy.go

@@ -59,7 +59,10 @@ func (d *DeployConfig) Deploy(ctx devspacecontext.Context, forceDeploy bool) (bo
 		chartPath = ctx.ResolvePath(chartPath)
 
 		// Check if the chart directory has changed
-		hash, err = hashpkg.Directory(chartPath)
+		hash, err = hashpkg.DirectoryExcludes(chartPath, []string{
+			".git/",
+			".devspace/",
+		}, true)
 		if err != nil {
 			return false, errors.Errorf("Error hashing chart directory: %v", err)
 		}

pkg/devspace/helm/v3/client.go

@@ -65,11 +65,12 @@ func (c *client) InstallChart(ctx devspacecontext.Context, releaseName string, r
 	// Chart settings
 	chartName := ""
 	if helmConfig.Chart.Source != nil {
-		chartName, err = c.DownloadChart(ctx, helmConfig)
+		chartName, err = dependencyutil.GetDependencyPath(ctx.WorkingDir(), helmConfig.Chart.Source)
 		if err != nil {
 			return nil, err
 		}
 
+		chartName = filepath.Dir(chartName)
 		args = append(args, chartName)
 	} else {
 		var chartRepo string

pkg/util/hash/hash.go

@@ -73,7 +73,6 @@ func Directory(path string) (string, error) {
 
 		return nil
 	})
-
 	if err != nil {
 		return "", err
 	}