Merge pull request #2286 from FabianKramm/main

FabianKramm · web-flow · commit 7948bdfe6392 · 2022-09-08T13:19:10.000+02:00
fix: make port forwarding non-blocking
diff --git a/pkg/devspace/kubectl/portforward/portforward.go b/pkg/devspace/kubectl/portforward/portforward.go
@@ -191,9 +191,11 @@ func NewOnAddresses(dialer httpstream.Dialer, addresses []string, ports []string
 }
 
 func (pf *PortForwarder) raiseError(err error) {
-	if pf.errChan != nil {
-		pf.errChan <- err
-	}
+	go func() {
+		if pf.errChan != nil {
+			pf.errChan <- err
+		}
+	}()
 
 	_ = pf.streamConn.Close()
 }

Original file line number	Diff line number	Diff line change
`@@ -191,9 +191,11 @@ func NewOnAddresses(dialer httpstream.Dialer, addresses []string, ports []string`
`191`	`191`	`}`
`192`	`192`
`193`	`193`	`func (pf *PortForwarder) raiseError(err error) {`
`194`		`- if pf.errChan != nil {`
`195`		`- pf.errChan <- err`
`196`		`- }`
	`194`	`+ go func() {`
	`195`	`+ if pf.errChan != nil {`
	`196`	`+ pf.errChan <- err`
	`197`	`+ }`
	`198`	`+ }()`
`197`	`199`
`198`	`200`	`_ = pf.streamConn.Close()`
`199`	`201`	`}`