Merge pull request #2222 from FabianKramm/main

fix: sync path parsing for windows

Author: FabianKramm

pkg/devspace/services/sync/controller.go

@@ -301,7 +301,10 @@ func ParseSyncPath(path string) (localPath string, remotePath string, err error)
 
 	splitted := strings.Split(path, ":")
 	if len(splitted) > 2 {
-		return "", "", fmt.Errorf("error in sync path %s: should have format local:remote", path)
+		newSplitted := []string{}
+		newSplitted = append(newSplitted, strings.Join(splitted[0:len(splitted)-1], ":"))
+		newSplitted = append(newSplitted, splitted[len(splitted)-1])
+		splitted = newSplitted
 	}
 
 	if len(splitted) == 1 {

pkg/devspace/services/sync/controller_test.go

@@ -0,0 +1,32 @@
+package sync
+
+import (
+	"gotest.tools/assert"
+	"testing"
+)
+
+type parseSyncPathTestCase struct {
+	name string
+	in   string
+
+	expectedLocal  string
+	expectedRemote string
+}
+
+func TestParseSyncPath(t *testing.T) {
+	testCases := []parseSyncPathTestCase{
+		{
+			name:           "Test Windows",
+			in:             "C:/codeproject:/home/dev/codeproject",
+			expectedLocal:  "C:/codeproject",
+			expectedRemote: "/home/dev/codeproject",
+		},
+	}
+
+	for _, testCase := range testCases {
+		local, remote, err := ParseSyncPath(testCase.in)
+		assert.NilError(t, err)
+		assert.Equal(t, local, testCase.expectedLocal, "Expect local path in "+testCase.name)
+		assert.Equal(t, remote, testCase.expectedRemote, "Expect remote path in "+testCase.name)
+	}
+}