broken petsc tests

Author: ZoeLeibowitz

devito/petsc/config.py

@@ -79,10 +79,7 @@ def get_petsc_type_mappings():
         petsc_type_to_ctype = {v: k for k, v in printer_mapper.items()}
         # Add other PETSc types
         petsc_type_to_ctype.update({
-            # KSPType is `const char*` into KSP-owned memory.  Using c_char_p
-            # would dereference that pointer when Python reads the struct, which
-            # segfaults after SNESDestroy frees the KSP.  An inline char array
-            # (c_char * N) stores a copy, so it is safe to read at any time.
+            # Store a copy so it doens't segfault after SNESDestroy
             'KSPType': ctypes.c_char * KSPTYPE_MAX_LEN,
             'KSPConvergedReason': petsc_type_to_ctype['PetscInt'],
             'KSPNormType': petsc_type_to_ctype['PetscInt'],

devito/petsc/iet/callbacks.py

@@ -648,8 +648,7 @@ def _create_initial_guess_body(self, body):
     def _make_constrain_bc(self):
         """
         Constructs the `CountBCs` and `SetPointBCs` efuncs. Works for both
-        single- and multi-field: all fields' expressions are compiled together
-        (clustering may fuse loops) and a single callback is emitted for each.
+        single- and multi-field.
         """
         constrain_bc = self.field_data.constrain_bc
         sobjs = self.solver_objs
@@ -863,10 +862,8 @@ def _create_set_point_bc_body(self, body, _constrain_bc_dict):
 
     def _create_set_point_bc_body_coupled(self, body):
         """
-        Combined SetPointBCs body for all target fields. The body is compiled
-        from all fields' point_bc_exprs together (loops may be fused by
-        clustering). Per-field counter symbols are substituted with the
-        corresponding bcPointsArr[k_iter] after assembly.
+        # TODO : ADD DOCS - MAKE IT CLEARER
+        Combined SetPointBCs body for all target fields.
         """
         linsolve_expr = self.inject_solve.expr.rhs
         objs = self.objs
@@ -892,8 +889,6 @@ def _create_set_point_bc_body_coupled(self, body):
         bcPointsIS = sobjs['bcPointsIS']
         bcCompsIS = sobjs['bcCompsIS']
 
-        # Zero-initialise IS arrays (PetscCalloc1 sets pointers to NULL so
-        # the automatic ISDestroy cleanup is safe even on early exit)
         is_array_mallocs = (
             petsc_call('PetscCalloc1', [nfields, Byref(bcPointsIS._C_symbol)]),
             petsc_call('PetscCalloc1', [nfields, Byref(bcCompsIS._C_symbol)]),
@@ -947,7 +942,6 @@ def _create_set_point_bc_body_coupled(self, body):
             stacks=(dm_get_local_info,) + derefs
         )
 
-        # Struct substitutions + per-field counter → bcArr[k_iter]
         subs = {i._C_symbol: FieldFromPointer(i._C_symbol, ctx) for
                 i in fields if not isinstance(i.function, AbstractFunction)}
         for t in targets: