refactor: messages calls service-open directly, no wrapper RPC

service-open now resolves a relative `path` against its workspaceRoot
(absolute paths unchanged), so a client holding only a workspace-relative
path can call it directly. The messages panel drops its
`devframes:plugin:messages:open-file` bridge (and DP_MESSAGES_0002) and
calls `devframes:service:open:open-in-editor` straight from the client.
Removes the now-dead DS_OPEN_0001 (paths are no longer required absolute).

Author: antfubot

docs/guide/services.md

@@ -153,7 +153,7 @@ state.on('updated', render)
 
 ### Built-in services
 
-**`@devframes/service-open`** (`devframes:service:open`) opens files in the user's editor (`open-in-editor`, with optional `line`/`column`) or reveals them in the OS file explorer (`open-in-finder`). Callers pass **absolute** paths; the service refuses anything outside the workspace root and the configured extra `roots` (`DS_OPEN_0002`), and gates editor commands to the `KNOWN_EDITORS` picklist. Options: `{ editor?, roots? }` — the preferred editor (later installer wins) and additional openable directories (merged as a union). It supersedes the per-plugin `devframe/recipes/common-rpc-functions` registrations, now deprecated.
+**`@devframes/service-open`** (`devframes:service:open`) opens files in the user's editor (`open-in-editor`, with optional `line`/`column`) or reveals them in the OS file explorer (`open-in-finder`). Paths may be absolute or relative to the workspace root (so a client with only a workspace-relative path — a message's file position, say — calls it directly); the service refuses anything outside the workspace root and the configured extra `roots` (`DS_OPEN_0002`), and gates editor commands to the `KNOWN_EDITORS` picklist. Options: `{ editor?, roots? }` — the preferred editor (later installer wins) and additional openable directories (merged as a union). It supersedes the per-plugin `devframe/recipes/common-rpc-functions` registrations, now deprecated.
 
 **`@devframes/service-shiki`** (`devframes:service:shiki`) renders [Shiki](https://shiki.style) syntax highlighting on the server, so plugin bundles stop shipping grammars and themes. Three RPC queries — `highlight` (dual-theme HTML), `code-to-hast`, and `code-to-tokens` (for renderers that own their DOM, e.g. diff views) — all client-`cacheable` and LRU-cached server-side per `(code, lang, themes)`. Unknown languages degrade to plain text. Options: `{ themes?, langs? }` — the default light/dark pair (defaults `vitesse-light`/`vitesse-dark`, matching the design system; later installer wins) and languages to eagerly load (merged as a union).
 

plugins/messages/src/client/App.vue

@@ -1,5 +1,8 @@
 <script setup lang="ts">
 import type { DevframeMessageAction, DevframeMessageEntry } from '@devframes/hub/types'
+// Types-only: loads service-open's RPC/scope augmentations so the scoped
+// `open.rpc.call('open-in-editor', …)` below is fully typed.
+import type {} from '@devframes/service-open'
 import type { DevframeConnectionStatus, DevframeRpcClient } from 'devframe/client'
 import DisplayBadge from '@antfu/design/components/Display/DisplayBadge.vue'
 import FormSearchField from '@antfu/design/components/Form/FormSearchField.vue'
@@ -108,7 +111,10 @@ async function onOpenFile(entry: DevframeMessageEntry): Promise<void> {
   if (!entry.filePosition)
     return
   const { file, line, column } = entry.filePosition
-  await props.rpc.call('devframes:plugin:messages:open-file', { file, line, column })
+  // Call the open wire service directly — it resolves the workspace-relative
+  // path itself. `file` may be relative or absolute.
+  const open = props.rpc.services.get('@devframes/service-open')
+  await open?.rpc.call('open-in-editor', { path: file, line, column })
 }
 </script>
 

plugins/messages/src/diagnostics.ts

@@ -14,9 +14,5 @@ export const diagnostics = defineDiagnostics({
         `"${p.id}" is mounted on a context without a hub messages host (\`ctx.messages\`) — its RPC surface stays registered but no-ops, so the panel will show an empty feed.`,
       fix: 'Mount this devframe through a hub host (`@devframes/hub`\'s `initHub`, or `createHubContext` + `ctx.install`) to get a live message feed.',
     },
-    DP_MESSAGES_0002: {
-      why: 'Cannot open the file: the "@devframes/service-open" wire service is not installed on this host.',
-      fix: 'Install the service package next to the messages plugin (it is declared in the plugin\'s `services`), or install it host-side via `ctx.services.install(createOpenService())`.',
-    },
   },
 })

plugins/messages/src/node/index.ts

@@ -17,10 +17,10 @@ export function setupMessages(ctx: DevframeNodeContext): void {
   if (!getMessagesHost(ctx))
     diagnostics.DP_MESSAGES_0001({ id: PLUGIN_ID })
 
-  // The detail panel's "open file" affordance delegates to the
+  // The detail panel's "open file" affordance calls the
   // `@devframes/service-open` wire service (declared in the definition's
-  // `services`) through `devframes:plugin:messages:open-file`, which
-  // resolves workspace-relative file positions server-side.
+  // `services`) directly from the client — the service resolves the
+  // workspace-relative file position itself, so the plugin needs no bridge.
   for (const fn of serverFunctions)
     ctx.rpc.register(fn)
 }

plugins/messages/src/rpc/functions/open-file.ts

@@ -2,7 +2,6 @@ import type { RpcDefinitionsToFunctions } from 'devframe/rpc'
 import { messagesAdd } from './functions/add'
 import { messagesClear } from './functions/clear'
 import { messagesList } from './functions/list'
-import { messagesOpenFile } from './functions/open-file'
 import { messagesRemove } from './functions/remove'
 import { messagesUpdate } from './functions/update'
 
@@ -17,7 +16,6 @@ export const serverFunctions = [
   messagesUpdate,
   messagesRemove,
   messagesClear,
-  messagesOpenFile,
 ] as const
 
 declare module 'devframe' {

plugins/messages/src/rpc/index.ts

@@ -43,16 +43,16 @@ describe('messages dev-server (hub context)', () => {
     expect(meta.websocket).toBe(server.port)
   })
 
-  it('registers the open-file bridge and the open service alongside the feed RPCs', () => {
+  it('installs the open service (called directly by the client) alongside the feed RPCs', () => {
     const names = Array.from(server.ctx.rpc.definitions.keys())
     expect(names).toContain('devframes:plugin:messages:list')
     expect(names).toContain('devframes:plugin:messages:add')
     expect(names).toContain('devframes:plugin:messages:update')
     expect(names).toContain('devframes:plugin:messages:remove')
     expect(names).toContain('devframes:plugin:messages:clear')
-    expect(names).toContain('devframes:plugin:messages:open-file')
-    // The declared `@devframes/service-open` wire service is installed and
-    // registers its own scoped RPC.
+    // The detail panel calls the declared `@devframes/service-open` wire
+    // service directly; the plugin registers no open-file bridge of its own.
+    expect(names).not.toContain('devframes:plugin:messages:open-file')
     expect(names).toContain('devframes:service:open:open-in-editor')
     expect(server.ctx.services.has('@devframes/service-open')).toBe(true)
   })

plugins/messages/test/dev-server.test.ts

@@ -6,10 +6,6 @@ import { defineDiagnostics } from 'devframe/utils/nostics'
 export const diagnostics = defineDiagnostics({
   docsBase: 'https://devfra.me/errors',
   codes: {
-    DS_OPEN_0001: {
-      why: (p: { path: string }) => `Refusing to open "${p.path}": the path is not absolute.`,
-      fix: 'Resolve the path on the caller side (e.g. against the workspace root or your plugin\'s managed directory) before calling the open service.',
-    },
     DS_OPEN_0002: {
       why: (p: { path: string }) => `Refusing to open "${p.path}": the path is outside the workspace root and every configured extra root.`,
       fix: 'The open service only touches files under the workspace root by default. Pass additional allowed directories via the service\'s `roots` option when your tool manages files elsewhere (e.g. a global storage dir).',

services/open/src/diagnostics.ts

@@ -26,7 +26,11 @@ export interface OpenServiceOptions {
 }
 
 export interface OpenInEditorInput {
-  /** Absolute path of the file to open. */
+  /**
+   * File to open — absolute, or relative to the service's `workspaceRoot`
+   * (so a client with only a workspace-relative path, e.g. a message's file
+   * position, can call this directly without a server-side bridge).
+   */
   path: string
   line?: number
   column?: number
@@ -57,11 +61,12 @@ declare module 'devframe' {
 /**
  * The open wire service — `open-in-editor` / `open-in-finder` RPC shared by
  * every plugin on the host, replacing per-plugin registrations of the
- * (deprecated) `devframe/recipes/common-rpc-functions` recipes. Callers pass
- * **absolute** paths; the service refuses paths outside the workspace root
- * and the configured extra {@link OpenServiceOptions.roots} (`DS_OPEN_0002`),
- * and gates editor commands to the `KNOWN_EDITORS` picklist so the RPC
- * surface can't spawn arbitrary commands.
+ * (deprecated) `devframe/recipes/common-rpc-functions` recipes. Paths may be
+ * absolute or relative to the `workspaceRoot`; the service refuses paths
+ * outside the workspace root and the configured extra
+ * {@link OpenServiceOptions.roots} (`DS_OPEN_0002`), and gates editor
+ * commands to the `KNOWN_EDITORS` picklist so the RPC surface can't spawn an
+ * arbitrary command.
  */
 export function createOpenService(options?: OpenServiceOptions): DevframeServiceDefinition<OpenServiceApi, OpenServiceOptions> {
   return {
@@ -74,11 +79,12 @@ export function createOpenService(options?: OpenServiceOptions): DevframeService
     setup(ctx, { options }) {
       const allowedRoots = [ctx.workspaceRoot, ...(options?.roots ?? [])].map(root => resolve(root))
 
-      /** Absolute + contained in one of the allowed roots, or throws. */
+      /**
+       * Resolve `path` (relative paths against `workspaceRoot`) and assert it
+       * lands inside one of the allowed roots, or throw.
+       */
       function assertAllowedPath(path: string): string {
-        if (!isAbsolute(path))
-          throw diagnostics.DS_OPEN_0001({ path })
-        const resolved = resolve(path)
+        const resolved = isAbsolute(path) ? resolve(path) : resolve(ctx.workspaceRoot, path)
         const contained = allowedRoots.some((root) => {
           const rel = relative(root, resolved)
           return rel === '' || (!rel.startsWith('..') && !isAbsolute(rel))

services/open/src/index.ts

@@ -66,15 +66,23 @@ describe('@devframes/service-open', () => {
     expect(launchEditor).toHaveBeenLastCalledWith(join(dir, 'a.ts'), 'zed')
   })
 
-  it('refuses relative paths and paths outside the allowed roots', async () => {
+  it('resolves relative paths against the workspace root', async () => {
+    const { ctx, dir } = await createCtx()
+    const install = ctx.services.install(createOpenService())
+    await ctx.services.ready()
+    const api = await install
+
+    await api!.openInEditor({ path: 'src/a.ts' })
+    expect(launchEditor).toHaveBeenCalledWith(join(dir, 'src/a.ts'), undefined)
+  })
+
+  it('refuses paths outside the allowed roots', async () => {
     const { ctx } = await createCtx()
     const install = ctx.services.install(createOpenService())
     await ctx.services.ready()
     const api = await install
 
-    await expect(api!.openInEditor({ path: 'src/a.ts' })).rejects.toThrowError(/not absolute/)
     await expect(api!.openInFinder({ path: '/etc/passwd' })).rejects.toThrowError(/outside the workspace root/)
-    expect(launchEditor).not.toHaveBeenCalled()
     expect(open).not.toHaveBeenCalled()
   })