Skip to content

Commit 2584a32

Browse files
committed
refactor: ottimizzazione controlli viste
1 parent 258a476 commit 2584a32

1 file changed

Lines changed: 1 addition & 33 deletions

File tree

modules/aggiornamenti/src/Controlli/ColonneDuplicateViste.php

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -59,39 +59,7 @@ public function check()
5959
]);
6060
}
6161

62-
// 2. Controllo viste diverse con stesso title nello stesso modulo e lingua
63-
$duplicati_title_diverse = database()->fetchArray('
64-
SELECT `zz_views`.`id_module`, `zz_views_lang`.`title`, `zz_views_lang`.`id_lang`,
65-
COUNT(DISTINCT `zz_views_lang`.`id_record`) as `count_viste`,
66-
GROUP_CONCAT(DISTINCT `zz_views`.`name`) as `nomi_viste`
67-
FROM `zz_views_lang`
68-
INNER JOIN `zz_views` ON `zz_views`.`id` = `zz_views_lang`.`id_record`
69-
WHERE `zz_views_lang`.`title` IS NOT NULL AND `zz_views_lang`.`title` != ""
70-
GROUP BY `zz_views`.`id_module`, `zz_views_lang`.`title`, `zz_views_lang`.`id_lang`
71-
HAVING COUNT(DISTINCT `zz_views_lang`.`id_record`) > 1
72-
');
73-
74-
foreach ($duplicati_title_diverse as $colonna) {
75-
$modulo = Module::find($colonna['id_module']);
76-
$lingua = database()->fetchOne('SELECT `name` FROM `zz_langs` WHERE `id` = '.prepare($colonna['id_lang']));
77-
78-
// Estrai solo la parte principale del nome della lingua (es. "English" da "English (English)")
79-
$nome_lingua = explode(' (', $lingua['name'])[0];
80-
81-
$this->addResult([
82-
'id' => 'title_diverse_' . $colonna['id_module'] . '_' . $colonna['id_lang'] . '_' . md5($colonna['title']),
83-
'nome' => $modulo->getTranslation('title') . ': ' . $colonna['title'] . ' (' . $nome_lingua . ')',
84-
'descrizione' => tr('Il titolo "_TITLE_" del modulo _MODULE_ è usato da _COUNT_ viste diverse (_VIEWS_) nella lingua _LANG_', [
85-
'_TITLE_' => $colonna['title'],
86-
'_MODULE_' => $modulo->getTranslation('title'),
87-
'_COUNT_' => $colonna['count_viste'],
88-
'_VIEWS_' => $colonna['nomi_viste'],
89-
'_LANG_' => $nome_lingua,
90-
]),
91-
]);
92-
}
93-
94-
// 3. Controllo record duplicati in zz_views_lang con stesso id_record e id_lang
62+
// 2. Controllo record duplicati in zz_views_lang con stesso id_record e id_lang
9563
$duplicati_record_lang = database()->fetchArray('
9664
SELECT `zz_views`.`id_module`, `zz_views_lang`.`id_record`, `zz_views_lang`.`id_lang`, COUNT(*) as `count`
9765
FROM `zz_views_lang`

0 commit comments

Comments
 (0)