Give consumers the ability to observe failures (via TraceListener, ET…#183
Closed
desjarlais wants to merge 1 commit into
Closed
Give consumers the ability to observe failures (via TraceListener, ET…#183desjarlais wants to merge 1 commit into
desjarlais wants to merge 1 commit into
Conversation
…W, Event Viewer, etc.) but still maintain the swallow exception flow.
Collaborator
|
Is this going to be no-op when there is no Trace Listener or Event Viewer etc. attached? |
Owner
Author
|
I don't think it will be a no-op, some overhead will be there, not sure how much of a cost that will be...I'm fine with taking or leaving it, just something I wanted to see if it would be worth adding. |
Collaborator
|
My thinking is that if someone wants to look at the trace log, they will probably launch it from Visual Studio in debug mode so it doesn't seem to add much value. Unless there is something I'm not aware of, I'm inclined to reject. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…W, Event Viewer, etc.) but still maintain the swallow exception flow.