-
Notifications
You must be signed in to change notification settings - Fork 15
Implement convenience command depot login-docker
#509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agdphd
wants to merge
5
commits into
depot:main
Choose a base branch
from
agdphd:agdphd/configure-docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eaf1c2e
Implement convenience command `depot login-docker`
agdphd 086d4e0
Fix string formatting
agdphd 1386502
Explicitly error if no orgID found
agdphd 8b2dd49
Use `helpers.ResolveProjectAuth` for failthrough token resolution
agdphd 1de5c65
Use org-scoped instead of project-scoped auth
agdphd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| package docker | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/depot/cli/pkg/config" | ||
| "github.com/depot/cli/pkg/dockerclient" | ||
| "github.com/depot/cli/pkg/helpers" | ||
| configtypes "github.com/docker/cli/cli/config/types" | ||
| registrytypes "github.com/docker/docker/api/types/registry" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| func NewCmdLoginDocker() *cobra.Command { | ||
| var ( | ||
| org string | ||
| token string | ||
| ) | ||
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "login-docker", | ||
| Short: "Log in Docker to the Depot registry with your user API token", | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| token, err := helpers.ResolveOrgAuth(cmd.Context(), token) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| if token == "" { | ||
| return fmt.Errorf("missing API token, please run `depot login`") | ||
| } | ||
|
|
||
| if org == "" { | ||
| org = config.GetCurrentOrganization() | ||
| } | ||
| if org == "" { | ||
| return fmt.Errorf("No organization configured; use the --org flag or verify your project configuration") | ||
| } | ||
|
|
||
| dockerCli, err := dockerclient.NewDockerCLI() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| serverAddress := org + ".registry.depot.dev" | ||
|
agdphd marked this conversation as resolved.
|
||
| client := dockerCli.Client() | ||
| _, err = client.RegistryLogin(cmd.Context(), registrytypes.AuthConfig{ | ||
| Username: "x-token", | ||
| Password: token, | ||
| ServerAddress: serverAddress, | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| cfg := dockerCli.ConfigFile() | ||
| creds := cfg.GetCredentialsStore(serverAddress) | ||
| err = creds.Store(configtypes.AuthConfig{ | ||
| Username: "x-token", | ||
| Password: token, | ||
| ServerAddress: serverAddress, | ||
| }) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| fmt.Println("Successfully stored Docker credentials for " + serverAddress) | ||
| return nil | ||
| }, | ||
| } | ||
|
|
||
| flags := cmd.Flags() | ||
| flags.StringVar(&org, "org", "", "Depot organization ID") | ||
| flags.StringVar(&token, "token", "", "Depot token") | ||
|
|
||
| return cmd | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.