Skip to content

External links in the manual screen can crash with ActivityNotFoundException #98

Description

@jim-daf

While reading through the manual screen I noticed that external links are handed straight to an ACTION_VIEW intent without checking whether anything on the device can open them.

In ManualScreen.kt the WebView client routes any non file URL out with context.startActivity(Intent(Intent.ACTION_VIEW, ...)). If the link points to a web page and there is no browser installed, or no app registered for that intent, startActivity throws ActivityNotFoundException and the screen goes down with it. This is easy to hit on minimal or de-Googled builds and on work profiles where the browser is locked down.

Wrapping the launch in a try/catch keeps the manual usable and turns the missing handler into a short message instead of a crash. I will put up a PR for it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions